Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyzmq: use zeromq4 #49533

Merged
merged 1 commit into from Oct 31, 2018
Merged

pythonPackages.pyzmq: use zeromq4 #49533

merged 1 commit into from Oct 31, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 31, 2018 •
edited

Motivation for this change

I can't find any reason anymore to use zeromq4. nix-review shows two failures: python3.pkgs.robotframework-tools and zeromq4-haskell. Both of those also fail without this commit. I'd mark them as broken, but the first would introduce a merge conflict with #49434 and I couldn't find out where the second is actually defined.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 31, 2018 15:59
@timokau
Copy link
Member Author

timokau commented Oct 31, 2018

@GrahamcOfBorg build python2.pkgs.pyzmq python3.pkgs.pyzmq

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pyzmq, python3.pkgs.pyzmq

Partial log (click to expand)

......................                                                   [100%]

============ 203 passed, 23 skipped, 40 deselected in 50.01 seconds ============
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/y43g5wzmnvp2i1hf77kdgy40mq54x0z5-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() running at /nix/store/y43g5wzmnvp2i1hf77kdgy40mq54x0z5-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:28> wait_for=<Future cancelled>>
pytestcachePhase
/nix/store/xkgnlpsm52s5v27ih396jkd5nmsjw7nq-python2.7-pyzmq-17.1.2
/nix/store/y43g5wzmnvp2i1hf77kdgy40mq54x0z5-python3.6-pyzmq-17.1.2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.pyzmq, python3.pkgs.pyzmq

Partial log (click to expand)

Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
builder for '/nix/store/zajha7rrg8pkxfgxdra3if9yvy6jjlgk-python3.6-pyzmq-17.1.2.drv' failed with exit code 1
error: build of '/nix/store/zajha7rrg8pkxfgxdra3if9yvy6jjlgk-python3.6-pyzmq-17.1.2.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pyzmq, python3.pkgs.pyzmq

Partial log (click to expand)

......................                                                   [100%]

============ 203 passed, 23 skipped, 40 deselected in 53.36 seconds ============
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() running at /nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:28> wait_for=<Future cancelled>>
pytestcachePhase
/nix/store/b8m0lvmv9731y1r6dlh3iz1zns6drind-python2.7-pyzmq-17.1.2
/nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2

@timokau
Copy link
Member Author

timokau commented Oct 31, 2018

The darwin failure is a regression. zmq.error.ZMQError: Address already in use reads a bit like it may be a transient sandboxing issue though. Lets retry

@GrahamcOfBorg build python3.pkgs.pyzmq

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.pyzmq

Partial log (click to expand)

/nix/store/y43g5wzmnvp2i1hf77kdgy40mq54x0z5-python3.6-pyzmq-17.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.pyzmq

Partial log (click to expand)

../../../../nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/tests/asyncio/test_asyncio.py . [ 90%]
......................                                                   [100%]

============ 203 passed, 23 skipped, 40 deselected in 50.54 seconds ============
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() running at /nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:28> wait_for=<Future cancelled>>
pytestcachePhase
/nix/store/x0w0h5yr96jjmv0ac136k9414lmn67zf-python3.6-pyzmq-17.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.pyzmq

Partial log (click to expand)

../../nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/tests/asyncio/test_asyncio.py . [ 90%]
......................                                                   [100%]

============ 203 passed, 23 skipped, 40 deselected in 48.44 seconds ============
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() done, defined at /nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:25> wait_for=<Future cancelled>>
Task was destroyed but it is pending!
task: <Task pending coro=<AsyncioAuthenticator.__handle_zap() running at /nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2/lib/python3.6/site-packages/zmq/auth/asyncio/__init__.py:28> wait_for=<Future cancelled>>
pytestcachePhase
/nix/store/99wal8qm0w5f22lx8hy6ssrd4a9cdadj-python3.6-pyzmq-17.1.2

@timokau
Copy link
Member Author

timokau commented Oct 31, 2018

There we go. I'll leave this open for a while in case anybody has a reason to stay with zeromq3.

@FRidh FRidh merged commit 4133885 into NixOS:master Oct 31, 2018
@timokau timokau deleted the pyzmq-zeromq4 branch November 1, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @FRidh