Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6742: Only possible to build station next to competitor by using CTRL+click #6831

Closed
wants to merge 2 commits into from

Conversation

Hopman
Copy link
Contributor

@Hopman Hopman commented Jun 22, 2018

Building stations next to an existing station of a competitor only worked by using CTRL+click.
#6742
This PR implements the suggested changes:

  • keep the possibility to build stations there
  • remove the need for CTRL+click

@Hopman
Copy link
Contributor Author

Hopman commented Jul 4, 2018

@SylvainDevidal you are correct.

The string "STR_ERROR_TOO_CLOSE_TO_ANOTHER_STATION" only appears in this one location, the language files and in scripts.

If desirable, I can extend the PR with another commit that removes the string completely.

@TrueBrain
Copy link
Member

Sorry for the slow reply: that would be very much appreciated. Please remove it from all language files! Thank you :)

Remove unused string "STR_ERROR_TOO_CLOSE_TO_ANOTHER_STATION"
from all language and scripting files.
@Hopman
Copy link
Contributor Author

Hopman commented Jul 20, 2018

Updated the PR.

@frosch123
Copy link
Member

I tried this, it now allows building a station next to a competitor station without CTRL.

However, if there are two competitor stations nearby, it still says "adjoins more than one existing station".
Is it also possible to improve this second case?

@Hopman
Copy link
Contributor Author

Hopman commented Jul 23, 2018

Is it also possible to improve this second case?

Looking into it.

@frosch123
Copy link
Member

Current PR is #6906.

@frosch123 frosch123 closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants