Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutter: 0.94 -> 0.94.2 #49546

Merged
merged 3 commits into from
Nov 3, 2018
Merged

shutter: 0.94 -> 0.94.2 #49546

merged 3 commits into from
Nov 3, 2018
+8 −7

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Oct 31, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2018

Well I was just looking at #46958
See comments there : at least one dep has changed

@c0bw3b c0bw3b mentioned this pull request Oct 31, 2018
Closed
@fadenb
Copy link
Contributor Author

fadenb commented Oct 31, 2018

I will take a look at it, did only do a superficial test by taking one screenshot.

@roberth roberth added the 8.has: package (update) This PR updates a package to a newer version label Oct 31, 2018
c0bw3b added 2 commits November 3, 2018 16:01
@c0bw3b
shutter: dependencies refresh

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6caffb5 
procps-ng and perlPackages.FileBaseDir were missing
Perl package JSONMaybeXS replaces JSONXS
Moved makeWrapper to nativeBuildInputs
@c0bw3b
shutter: use procps as build input

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2b0ecb1 
procps-ng actually is an alias to procps attr name
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

@GrahamcOfBorg build shutter

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: shutter

Partial log (click to expand)

/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/plugins/shell/sptornedpaper/sptornedpaper: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/plugins/shell/spraise/spraise: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/upload_plugins/upload/ToileLibre.pm: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/upload_plugins/upload/Imgur.pm: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/upload_plugins/upload/Dropbox.pm: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/upload_plugins/upload/vgyme.pm: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/share/shutter/resources/system/upload_plugins/upload/Gyazo.pm: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2/bin/.shutter-wrapped: interpreter directive changed from " /usr/bin/perl" to "/nix/store/0ingn8cwwnl84i374hcl6nafsm2c5m2p-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2...
/nix/store/bzkzax32ch72wi0cdy41a6n20z43qvv1-shutter-0.94.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: shutter

Partial log (click to expand)

/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/shell/spgrayscale/spgrayscale: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spwatermark/spwatermark: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spshadow/spshadow: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spsepia/spsepia: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spresize/spresize: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/sppolaroid/sppolaroid: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spnegate/spnegate: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2/share/shutter/resources/system/plugins/perl/spbardistortion/spbardistortion: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/bzgcpj9fijmlxgjaa72fjys7m3ycijy8-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2...
/nix/store/h6kbrpj12vdza33xvpz02q1ml12mijcn-shutter-0.94.2

@c0bw3b c0bw3b merged commit 5a1708b into NixOS:master Nov 3, 2018
@fadenb fadenb deleted the shutter_0.94.2 branch November 4, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fadenb @c0bw3b @GrahamcOfBorg @roberth