Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c-ares: 1.14.0 -> 1.15.0 #49548

Merged
merged 1 commit into from Nov 2, 2018
Merged

c-ares: 1.14.0 -> 1.15.0 #49548

merged 1 commit into from Nov 2, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 31, 2018

Motivation for this change

https://c-ares.haxx.se/changelog.html#1_15_0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: c-ares

Partial log (click to expand)

make[1]: Leaving directory '/build/c-ares-1.15.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0
shrinking /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0/lib/libcares.so.2.3.0
gzipping man pages under /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0/lib
patching script interpreter paths in /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0
checking for references to /build in /nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0...
/nix/store/j5cngyhb9y72jpk7cx40s0ky4mcag8x7-c-ares-1.15.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: c-ares

Partial log (click to expand)

make[1]: Leaving directory '/build/c-ares-1.15.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0
shrinking /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0/lib/libcares.so.2.3.0
gzipping man pages under /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0/lib
patching script interpreter paths in /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0
checking for references to /build in /nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0...
/nix/store/ghb5ymx9vb9l6nh6ww2xr7fm7yymk57n-c-ares-1.15.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: c-ares

Partial log (click to expand)

[180/180] Link: Build/CoreFoundation/libCoreFoundation.dylib
ld: warning: directory not found for option '-L../bootstrap/x86_64-apple-darwin/usr/lib'
ld: warning: undefined base symbol '__TMC15SwiftFoundation19_NSCFConstantString' for alias '___CFConstantStringClassReference'
installing
post-installation fixup
strip is /nix/store/2ws9cmamvr7xyvdg4d2nnd1bmr1zjrrq-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/jidd9w9lx7h1wxaz5gshlz052f77jg70-swift-corefoundation
cannot build derivation '/nix/store/hcr5iaanrbzja81357km6kh2xg44q6a9-stdenv-darwin.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ir93i6y6k6vwvagdh2l3lpi3igk119lk-c-ares-1.15.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ir93i6y6k6vwvagdh2l3lpi3igk119lk-c-ares-1.15.0.drv' failed

@dtzWill dtzWill merged commit 9e23f72 into NixOS:master Nov 2, 2018
@dtzWill dtzWill deleted the update/c-ares-1.15.0 branch November 2, 2018 08:56
@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2018

Whoops meant this to go to staging with the curl update. Sorry for rebuilds, revert if that is a problem.

vcunat added a commit that referenced this pull request Nov 2, 2018
@vcunat
Re-revert "c-ares: 1.14.0 -> 1.15.0"
4dd0482 
This reverts commit 87e4e1b
It's a mass rebuild, moving from master.  /cc #49548
@vcunat
Copy link
Member

vcunat commented Nov 2, 2018

Moved by 4dd0482. Current nixos-unstable is lagging a lot due to various problems, so I'd prefer if we could advance it fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @vcunat @roberth