Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-hardkernel: 4.14.73-149 -> 4.14.78-150 #49535

Merged
merged 1 commit into from Oct 31, 2018
Merged

linux-hardkernel: 4.14.73-149 -> 4.14.78-150 #49535

merged 1 commit into from Oct 31, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Oct 31, 2018

Motivation for this change

Standard version bump. Tested on my Odroid HC1, seems to build and boot nicely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@qolii qolii mentioned this pull request Oct 31, 2018
Closed
4 tasks
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

What slightly confuses me is that this causes a bunch of rebuilds for other platforms.
And why does Hydra build hardkernel modules ? https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=hardkernel

@qolii
Copy link
Contributor Author

qolii commented Oct 31, 2018

@xeji, I am afraid I've no idea, I don't know how Hydra really works :( I am also confused about that. (And also confused about why GrahamcOfBorg labels it as causing 101-500 linux rebuilds. Do really that many packages depend on the kernel?)

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

These rebuilds are all for other platforms while hardkernel is only for armv7.
Building modules based on hardkernel for x86_64-linux etc. makes no sense. There must be a bug somewhere. Anyway, it shouldn't be your problem 😄

@xeji xeji merged commit a2d39a8 into NixOS:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qolii @xeji @GrahamcOfBorg