x265: 2.7 -> 2.9 #49540
x265: 2.7 -> 2.9 #49540
Conversation
Encoder enhancements, AVX-512 support, ...
roberth
added
the
8.has: package (update)
| @@ -16,14 +16,14 @@ in | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "x265-${version}"; | |||
| version = "2.7"; | |||
| version = "2.9"; | |||
|
|
|||
| src = fetchurl { | |||
| urls = [ | |||
| "http://get.videolan.org/x265/x265_${version}.tar.gz" | |||
| "https://github.com/videolan/x265/archive/${version}.tar.gz" | |||
There was a problem hiding this comment.
GitHub archive tarballs are not stable over time. Once it gets regenerated the expected SHA hash won't match.
As an alternative URL we could instead use one of:
http://ftp.videolan.org/pub/videolan/x265/x265_2.9.tar.gz
ftp://ftp.videolan.org/pub/videolan/x265/x265_2.9.tar.gz
https://bitbucket.org/multicoreware/x265/downloads/x265_2.9.tar.gz
There was a problem hiding this comment.
What about just removing the github link?
There was a problem hiding this comment.
It would work too yes. But then we lose the insurance of having a fallback server to fetch from.
Not that this is a critical piece of software in the whole <nixpkgs> set but some day the fallback could avoid a number of Hydra build failures.
Co-Authored-By: grische <grische@users.noreply.github.com>
|
I'll push this to staging (because of the rebuilds number) with PR #50362 |
Janik-Haag
added
the
12. first-time contribution
Encoder enhancements, AVX-512 support, ...
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)