Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: 2.0.19 -> 2.0.24 #48644

Merged
merged 1 commit into from Oct 18, 2018
Merged

trezord: 2.0.19 -> 2.0.24 #48644

merged 1 commit into from Oct 18, 2018

Conversation

roconnor-blockstream
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Tested trezord by running the NixOS trezord module.

@roconnor-blockstream
Copy link
Contributor Author

@1000101 would you like to review?

@1000101
Copy link
Member

1000101 commented Oct 18, 2018

@1000101 would you like to review?

Thanks, it's all good, you beat me to it ;). There will be a small update on the udev rules though, that's why I didn't create the PR just yet. But I'll just open a separate PR, this version of the bridge will still work with the old udev rules.

@roconnor roconnor merged commit c7e7e16 into NixOS:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor-blockstream @1000101 @roconnor @GrahamcOfBorg