Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.3.7 -> 2.3.8, 2.4.4 -> 2.4.5, 2.5.1 -> 2.5.2 #48650

Merged
merged 3 commits into from Oct 18, 2018
Merged

ruby: 2.3.7 -> 2.3.8, 2.4.4 -> 2.4.5, 2.5.1 -> 2.5.2 #48650

merged 3 commits into from Oct 18, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 18, 2018

Motivation for this change

CVE-2018-16396
CVE-2018-16395

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from zimbatm as a code owner October 18, 2018 01:12
@marsam marsam changed the title ruby: 2.3.7 -> 2.3.8, 2.4.5 -> 2.4.5, 2.5.1 -> 2.5.2 ruby: 2.3.7 -> 2.3.8, 2.4.4 -> 2.4.5, 2.5.1 -> 2.5.2 Oct 18, 2018
@samueldr
Copy link
Member

@GrahamcOfBorg build ruby_2_5 ruby_2_4 ruby_2_3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ruby_2_5, ruby_2_4, ruby_2_3

Partial log (click to expand)

/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2/lib/libruby.2.5.2.dylib: fixing dylib
/nix/store/yf2j20awdi4mwh7vagraarmlh9d93zjf-ruby-2.5.2
/nix/store/69a35sxhyrf1qabhpdx8k4g0fvzx5r4i-ruby-2.4.5
/nix/store/vz9yg7pk1pp3r22mch5m3abx8xmn8p2i-ruby-2.3.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby_2_5, ruby_2_4, ruby_2_3

Partial log (click to expand)

shrinking /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5/lib  /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5/bin
patching script interpreter paths in /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5
checking for references to /build in /nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5...
/nix/store/1a6y84bahfj17f61am73a96ipaci80z4-ruby-2.5.2
/nix/store/8xrq9fhgx2cg7c7kprgw6qcyaq0j9xya-ruby-2.4.5
/nix/store/1m2ngn38yv8lk0lgkymb404cp9cpnzxg-ruby-2.3.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby_2_5, ruby_2_4, ruby_2_3

Partial log (click to expand)

shrinking /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2/lib/ruby/2.5.0/x86_64-linux/enc/iso_8859_5.so
shrinking /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2/bin/ruby
gzipping man pages under /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2/lib  /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2/bin
patching script interpreter paths in /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2
checking for references to /build in /nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2...
/nix/store/fpv0gilf7m6fxr66q2vr15k0jkcxa0hh-ruby-2.5.2
/nix/store/8bklfy1zk7vlira58zpl92sazsxs7zaw-ruby-2.4.5
/nix/store/7kl66rq544991ds555gz8x62k36wyac5-ruby-2.3.8

@zimbatm
Copy link
Member

zimbatm commented Oct 18, 2018

thanks @marsam!

@zimbatm zimbatm merged commit ef7b128 into NixOS:master Oct 18, 2018
zimbatm added a commit that referenced this pull request Oct 18, 2018
@zimbatm
Merge pull request #48650 from marsam/feature/update-ruby
2f82603 
ruby: 2.3.7 -> 2.3.8, 2.4.4 -> 2.4.5, 2.5.1 -> 2.5.2
@zimbatm
Copy link
Member

zimbatm commented Oct 18, 2018

cherry-picked as 2f82603 in 18.09 with git cherry-pick -m 1 ef7b128 and forgot to put the -x

@marsam marsam deleted the feature/update-ruby branch October 18, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
1.severity: security 6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @samueldr @GrahamcOfBorg @zimbatm