Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTION.md #48646

Closed
wants to merge 1 commit into from
Closed

Create CONTRIBUTION.md #48646

wants to merge 1 commit into from

Conversation

hiiruki
Copy link

@hiiruki hiiruki commented Oct 17, 2018

Add CONTRIBUTION.md

Add CONTRIBUTION.md
@Synthetica9
Copy link
Member

Don't like it, this sort of thing should:

  1. Be discussed first, probably via an RFC
  2. Not be done before we see what sort of fallout the exact same thing will have on the Linux project.

@matthewbauer
Copy link
Member

matthewbauer commented Oct 17, 2018

There is alread a .github/CONTRIBUTING.md file:

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

It could definitely use improvements though!

@Ma27
Copy link
Member

Ma27 commented Oct 18, 2018

Be discussed first, probably via an RFC

👍. Although this means a lot more work for the author I think that altering contribution guidelines is a fundemental change where an RFC is appropriate.

I think that the contributing guidelines you're adding/modifying here should mention as well that in case of really fundamental changes an RFC should be written first :)

@FRidh
Copy link
Member

FRidh commented Oct 18, 2018

As pointed out by @matthewbauer the file already exists. If you can think of improvements, please go ahead and open a PR, issue, or RFC depending on the scope of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants