Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.27.2 -> 1.28.0 #48070

Merged
merged 1 commit into from Oct 10, 2018
Merged

vscode: 1.27.2 -> 1.28.0 #48070

merged 1 commit into from Oct 10, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 8, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently running this locally.
I also verified all of the hashes.

cc @Mic92 @xeji

@Mic92 Mic92 merged commit bd778b9 into NixOS:master Oct 10, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 10, 2018

Now the holy question: backport or not to backport?

@worldofpeace
Copy link
Contributor

Yes, the people need the latest vscode ⚡

@Mic92
Copy link
Member

Mic92 commented Oct 10, 2018

I also think it make sense for user-facing applications like firefox and vscode to backport.
Especially since the plugin ecosystem probably expects users to upgrade.
@NeQuissimus @bkchr Opinions?

@worldofpeace worldofpeace mentioned this pull request Dec 14, 2018
Merged
10 tasks
@eadwu eadwu deleted the vscode/1.28.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @Mic92 @worldofpeace @GrahamcOfBorg