Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: add libxcb to steamrt overrides #48084

Merged
merged 1 commit into from Oct 13, 2018
Merged

steam: add libxcb to steamrt overrides #48084

merged 1 commit into from Oct 13, 2018

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Oct 8, 2018

This fixes 'glXChooseVisual failed' when starting steam on mesa after
the libxcb 1.12 -> 1.13 upgrade.

Motivation for this change

Fixes #47932

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@corngood
steam: add libxcb to steamrt overrides
c7fa58f 
This fixes 'glXChooseVisual failed' when starting steam on mesa after
the libxcb 1.12 -> 1.13 upgrade.
@corngood
Copy link
Contributor Author

corngood commented Oct 8, 2018

Steam was broken by 155e017.

I believe the problem was that libGLX (from /run/opengl-drivers-32) is built against libxcb 1.13, but an incompatible version was being loaded from steamrt.

Chiiruno
Chiiruno approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me, I can't find any problems.

@joachifm joachifm merged commit 30008a1 into NixOS:master Oct 13, 2018
vcunat pushed a commit that referenced this pull request Nov 25, 2018
@joachifm @vcunat
Merge #48084: steam: add libxcb to steamrt overrides
3559a64 
(cherry picked from commit 30008a1)

Fixes #47932.  On 18.09 we still have libxcb 1.12, but I expect the
change will help with mixing versions, and it seems safe anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Chiiruno approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

steam: glXChooseVisual failed
4 participants
@corngood @Chiiruno @joachifm @GrahamcOfBorg