quickserve: init at 2018 #48083
Merged
quickserve: init at 2018 #48083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: quickserve Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: quickserve Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: quickserve Partial log (click to expand)
|
makefu
reviewed
Oct 9, 2018
| @@ -0,0 +1,33 @@ | |||
| { stdenv, fetchzip, python3, python3Packages, writeScript }: let | |||
| threaded_servers = python3Packages.buildPythonPackage { | |||
There was a problem hiding this comment.
I think it would be more clean if the threaded_server module is included into pkgs/python-modules instead of inlining it here.
There was a problem hiding this comment.
IMHO, this would only make sense if it would ever be used by something else than quickserve.
But now threaded_server is basically quickserve.
|
Success on aarch64-linux (full log) Attempted: quickserve Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: quickserve Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: quickserve Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)