Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb.connector-c: 2.3.6 -> 2.3.7 #48078

Merged
merged 1 commit into from Oct 16, 2018
Merged

mariadb.connector-c: 2.3.6 -> 2.3.7 #48078

merged 1 commit into from Oct 16, 2018

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Oct 8, 2018 •
edited

Motivation for this change

https://mariadb.com/kb/en/library/mariadb-connector-c-237-changelog/

This includes a security update, so it should be updated to stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 10, 2018

Mass rebuild, please rebase on staging.

@florianjacob florianjacob changed the base branch from master to staging October 15, 2018 15:06
@florianjacob
Copy link
Contributor Author

@xeji sorry, and thank you for teaching me what staging is for.
Rebased and switched PR to go to staging, Is this correct now? (Could not find much information on staging vs. staging-next and staging-19.03)

@florianjacob
Copy link
Contributor Author

(requesting review from code owners was some strange artifact from switching from master to staging, sorry for the noise)

@Mic92 Mic92 removed request for Mic92, LnL7 and FRidh October 15, 2018 21:45
@xeji
Copy link
Contributor

xeji commented Oct 16, 2018

Yes, staging is correct, that's where mass-rebuild PRs usually go to. (staging-next is to fix/stabilize a snapshot of staging before merging to master. staging-18.09 is for mass-rebuild changes to 18.09).

@GrahamcOfBorg build mariadb.connector-c unixODBCDrivers.mariadb

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mariadb.connector-c, unixODBCDrivers.mariadb

Partial log (click to expand)

-- Installing: /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10/./share/doc/mariadb_connector_odbc/README
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10
shrinking /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10/lib/libmaodbc.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10/lib
patching script interpreter paths in /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10
checking for references to /build in /nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10...
/nix/store/wxqk754zwnxwhz03n8ycdbfp0kv0dh3d-mariadb-connector-c-2.3.7
/nix/store/l35s9126vdm7b5a9rw4jlsyirwgpgmfa-mariadb-connector-odbc-2.0.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mariadb.connector-c, unixODBCDrivers.mariadb

Partial log (click to expand)

-- Installing: /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10/./share/doc/mariadb_connector_odbc/README
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10
shrinking /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10/lib/libmaodbc.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10/lib
patching script interpreter paths in /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10
checking for references to /build in /nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10...
/nix/store/lq6phqlphz9247m53dq0wp1vs7amkr82-mariadb-connector-c-2.3.7
/nix/store/jy3yw172jygnlzfj0zz2371z8xz4amq8-mariadb-connector-odbc-2.0.10

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: mariadb.connector-c

The following builds were skipped because they don't evaluate on x86_64-darwin: unixODBCDrivers.mariadb

Partial log (click to expand)

cannot build derivation '/nix/store/6gyhhmffxc3n3ix3x1wn4s5fqisk7c26-xnu-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/9xa79rfilv70lfgpvd7rvsp5khqhh1kx-IOKit-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gs1k4wvlinanf68kar02vfljddrlpjy8-curl-7.61.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/51z57c74fhk499pr7n6bi1ir96ihrcaq-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/0pzdp7frrqjk1511pn1v8ngwrw6y4py2-python-2.7.15.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/na1m677g7g6w2f6kd20p2dhk9x6sadi0-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/0md94qwim378yzf2li5lfwy93g9vgixa-libarchive-3.3.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/254vdhqq1bvns1rln5snn8958m6h4jgf-cmake-3.12.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/30lz14fv7rgzrrbhg8awf22rchkgicz7-mariadb-connector-c-2.3.7.drv': 4 dependencies couldn't be built
error: build of '/nix/store/30lz14fv7rgzrrbhg8awf22rchkgicz7-mariadb-connector-c-2.3.7.drv' failed

@xeji xeji merged commit 98e5a0f into NixOS:staging Oct 16, 2018
xeji pushed a commit that referenced this pull request Oct 16, 2018
@florianjacob @xeji
mariadb.connector-c: 2.3.6 -> 2.3.7 (#48078)
ab27d00 
(cherry picked from commit 98e5a0f)

contains security fix for CVE-2018-3081
@xeji
Copy link
Contributor

xeji commented Oct 16, 2018

backported to staging-18.09 in ab27d00

@florianjacob florianjacob deleted the mariadb-connector-c branch October 16, 2018 07:15
@florianjacob
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @xeji @GrahamcOfBorg