Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnome3: don't autoenable gdm #48080

Merged
merged 1 commit into from Oct 9, 2018
Merged

nixos/gnome3: don't autoenable gdm #48080

merged 1 commit into from Oct 9, 2018

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Oct 8, 2018

This seems to cause problems if people have other display-managers
enabled

#47945

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This seems to cause problems if people have other display-managers
enabled
@worldofpeace
Copy link
Contributor

What's the concensus on desktop-managers auto-enabling display-managers mapped to where it would make sense?

Your commit msg at fc035da says

If plasma5 is used as desktop-manager use sdddm.
If gnome3 is used as desktop-manager use gdm.

However if i do services.xserver.desktopManager.plasma5.enable = true;
it's lightdm not sddm.

I think this "auto-enabling" would make sense to have as long as it never interferes with someone enabling a different display-manager or enabling multiple desktop-managers.

Since this "auto-enabling" is only for gnome3 and it interferes with peoples use in an obtrusive way I think it's fine to remove this here.

@Lassulus
Copy link
Member Author

Lassulus commented Oct 9, 2018

Auto-enabling needs more logic than I thought. So we can enable gdm automatically if someone doesn't enable any other display-manager and light-dm is only by default enabled. Same for sddm/plasma.

But the easy fix is first to remove the gdm activation and cherry-pick this commit also to 18.09.

@worldofpeace
Copy link
Contributor

cc @jtojnar @hedning

@Mic92 Mic92 merged commit af7c572 into NixOS:master Oct 9, 2018
@Mic92
Copy link
Member

Mic92 commented Oct 9, 2018

Hopefully not too many people depend on this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants