Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses #48081

Merged
merged 6 commits into from Oct 10, 2018
Merged

Add licenses #48081

merged 6 commits into from Oct 10, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Another round for #43716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa changed the title Licenses 19 Add licenses Oct 8, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dclxvi, enchant, farstream, libungif

Partial log (click to expand)

copying path '/nix/store/gc1fdzb4c62645k3r1wcbpyncpy4ymrd-gssdp-1.0.2-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/scg8dy515xj1yznn36kh0qd60jvkdqbn-gupnp-igd-0.2.5' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/myyw2n86n0w0qm27qg1nvdxaaxccj3kk-gupnp-1.0.3-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/vd79c4y8px6lbb29vybqg2g4q1j59r5n-gupnp-igd-0.2.5-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/9b5307fbshi3fp9ih4x4y1wz13x2bnlf-libnice-0.1.14' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/ykh6djbx5zzlz3m5plid90vszpmx7fw6-farstream-0.2.8' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/hhnmyw2174f7ikjv6m08s7wn0gsyd6sy-dclxvi-2013-01-27
/nix/store/7msc9zwq2kf0q8k6qs7js2i37n8izcni-enchant-1.6.0
/nix/store/ykh6djbx5zzlz3m5plid90vszpmx7fw6-farstream-0.2.8
/nix/store/a9jy0lbmlgr65qniib5nrynfrkb5kj08-libungif-4.1.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: enchant, farstream, libungif

The following builds were skipped because they don't evaluate on aarch64-linux: dclxvi

Partial log (click to expand)

shrinking /nix/store/5nbv73mhiv36f8amrdlq7bw57n5riixj-farstream-0.2.8/lib/libfarstream-0.2.so.5.1.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nbv73mhiv36f8amrdlq7bw57n5riixj-farstream-0.2.8/lib
patching script interpreter paths in /nix/store/5nbv73mhiv36f8amrdlq7bw57n5riixj-farstream-0.2.8
checking for references to /build in /nix/store/5nbv73mhiv36f8amrdlq7bw57n5riixj-farstream-0.2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/9i5bipzjh4ghvjz4gnp23374jnd0vkq3-farstream-0.2.8-dev
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9i5bipzjh4ghvjz4gnp23374jnd0vkq3-farstream-0.2.8-dev/lib
patching script interpreter paths in /nix/store/9i5bipzjh4ghvjz4gnp23374jnd0vkq3-farstream-0.2.8-dev
checking for references to /build in /nix/store/9i5bipzjh4ghvjz4gnp23374jnd0vkq3-farstream-0.2.8-dev...

c0bw3b
c0bw3b approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified repos and sources and the whole batch LGTM.

@xeji xeji merged commit 6165117 into NixOS:master Oct 10, 2018
@markuskowa markuskowa deleted the licenses-19 branch October 10, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @GrahamcOfBorg @c0bw3b @xeji