Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.av: 0.4.1 -> 0.5.3 #48079

Merged
merged 1 commit into from Oct 12, 2018
Merged

pythonPackages.av: 0.4.1 -> 0.5.3 #48079

merged 1 commit into from Oct 12, 2018

Conversation

lopsided98
Copy link
Contributor

Things done

Update av to the latest version.

I switched to using a newer version of ffmpeg (it was previously using ffmpeg 2, which is no longer supported by this library). I also removed libav as a build input, because it does not seem to be necessary.

I've tested it with aiortc (out of nixpkgs tree) and it seems to work correctly.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 requested a review from FRidh as a code owner October 8, 2018 21:06
@srhb
Copy link
Contributor

srhb commented Oct 12, 2018

@GrahamcOfBorg build pythonPackages.av

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.av

Partial log (click to expand)

  The script pyav is installed in '/nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed av-0.5.3
/private/tmp/nix-build-python2.7-av-0.5.3.drv-0/av-0.5.3
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3/lib  /nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3/bin
patching script interpreter paths in /nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3
wrapping `/nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3/bin/pyav'...
/nix/store/6dgm795yh4y40kyyjzn0lhyi6k2yaa0g-python2.7-av-0.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.av

Partial log (click to expand)

shrinking /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/lib/python2.7/site-packages/av/container/output.so
shrinking /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/lib/python2.7/site-packages/av/container/streams.so
shrinking /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/lib/python2.7/site-packages/av/container/core.so
shrinking /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/lib/python2.7/site-packages/av/container/pyio.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/lib  /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/bin
patching script interpreter paths in /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3
checking for references to /build in /nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3...
wrapping `/nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3/bin/pyav'...
/nix/store/7fn4ic1js5s6lq3fw363bhk6xfvd8d9k-python2.7-av-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.av

Partial log (click to expand)

shrinking /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/lib/python2.7/site-packages/av/packet.so
shrinking /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/lib/python2.7/site-packages/av/plane.so
shrinking /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/lib/python2.7/site-packages/av/stream.so
shrinking /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/lib/python2.7/site-packages/av/utils.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/lib  /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/bin
patching script interpreter paths in /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3
checking for references to /build in /nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3...
wrapping `/nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3/bin/pyav'...
/nix/store/xip48gaqvhnls62dvc4m7zh0w6fa355c-python2.7-av-0.5.3

@srhb srhb merged commit 9cba2f5 into NixOS:master Oct 12, 2018
@lopsided98 lopsided98 deleted the python-av-update branch October 12, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @srhb @GrahamcOfBorg