Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: 7.5.6 -> 8.0.2 [18.03 backport] #48063

Merged
merged 5 commits into from Oct 8, 2018
Merged

tor-browser-bundle-bin: 7.5.6 -> 8.0.2 [18.03 backport] #48063

merged 5 commits into from Oct 8, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 8, 2018 •
edited

Motivation for this change

For security-sensitive applications like this it is better to stick to supported versions, also this means we have to perform major version upgrades. cc @joachifm @andir
The less-preferred alternative would be to mark it as insecure in 18.03 since there have been security fixes in 8.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

joachifm and others added 5 commits October 8, 2018 17:51
@joachifm @Mic92
tor-browser-bundle-bin: 7.5.6 -> 8.0
ce2ca32 
(cherry picked from commit ed5283f)
@joachifm @Mic92
tor-browser-bundle-bin: add gsettings-schemas
27b1d39 
See NixOS#46587

(cherry picked from commit 5710ee3)
@joachifm @Mic92
tor-browser-bundle-bin: parameterize icon theme
3cb4c06 
(cherry picked from commit 546e511)
@joachifm @Mic92
tor-browser-bundle-bin: 8.0 -> 8.0.1
cff09f3 
(cherry picked from commit f2ba1a4)
@andir @Mic92
tor-browser-bundle-bin: 8.0.1 -> 8.0.2
0d9f8d4 
Update to latest version due to security updates and 8.0.1 not being
available on the mirrors anymore.

Release notes: https://blog.torproject.org/new-release-tor-browser-802

(cherry picked from commit 248ed35)
@Mic92 Mic92 mentioned this pull request Oct 8, 2018
Merged
9 tasks
@joachifm joachifm merged commit c56ede7 into NixOS:release-18.03 Oct 8, 2018
@Mic92 Mic92 deleted the torbrowser-bundle-bin branch October 8, 2018 17:32
@joachifm
Copy link
Contributor

joachifm commented Oct 8, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @joachifm @GrahamcOfBorg @andir