Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium/update.sh: don't use remote builders, lots of copying for work #48090

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 9, 2018

When using a machine setup for distributed builds, current script will download
the huge sources and copy them to a remote builder to perform some minor calculation
(perhaps computing the hash, not sure).

Using remote builders for this is rather unlikely to 'pay off' even with a very fast link,
since the size of the data copied is so large compared to what it's used for.

This tweaks the script to avoid using remote builders.

Hopefully this sounds good to everyone, but especially the person(s) who normally update our chrome bits :).
If not, whatever works best for that person is probably the way to go.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably use --no-build-hook but this is fine too.

@bendlas
Copy link
Contributor

bendlas commented Oct 12, 2018

Can't judge the merits of this, but update still runs for me. Following @aszlig 's assessment
4b7de15

@bendlas bendlas closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants