Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codimd: update patch and fix test #48075

Merged
merged 2 commits into from Oct 10, 2018
Merged

codimd: update patch and fix test #48075

merged 2 commits into from Oct 10, 2018

Conversation

WilliButz
Copy link
Member

Motivation for this change

I updated my PR, which was recently merged into master of CodiMD, so the checksum of the included patch changed.

Also the test still seems to be non-deterministic after #47179, because the first request right after startup results only sometimes in a 503. Now there is a waitUntilSucceeds for this request, because a consecutive request always works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: codimd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: codimd

Partial log (click to expand)

            + 2 hidden modules
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0/lib  /nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0/bin
patching script interpreter paths in /nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0
/nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0/bin/manage_users: interpreter directive changed from "/usr/bin/env node" to "/nix/store/97sc9in4rx7nix11x40ibyjqrx2mbmpc-nodejs-6.14.4/bin/node"
checking for references to /build in /nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0...
/nix/store/6k6v1jlifp41dzh27d2dzzfx0z1z4pr1-codimd-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: codimd

Partial log (click to expand)

            + 2 hidden modules
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0/lib  /nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0/bin
patching script interpreter paths in /nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0
/nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0/bin/manage_users: interpreter directive changed from "/usr/bin/env node" to "/nix/store/kir61dr3zpfd7qig3qf4hy2chgb5ilyq-nodejs-6.14.4/bin/node"
checking for references to /build in /nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0...
/nix/store/xn7698q4l4cinmacwwv8ggm0yr161ppm-codimd-1.2.0

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test codimd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.codimd

Partial log (click to expand)

codimdSqlite: running command: sync
codimdSqlite: exit status 0
2 out of 2 tests succeeded
test script finished in 27.34s
cleaning up
killing codimdPostgres (pid 600)
killing codimdSqlite (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/k6j6ijvkvdjxx28c7axx59swv6557lvl-vm-test-run-codimd

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.codimd

Partial log (click to expand)

codimdPostgres: exit status 0
0 out of 2 tests succeeded
test script finished in 1853.14s
cleaning up
killing codimdSqlite (pid 631)
killing codimdPostgres (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/zchyqkb2l62rqm9wi5a4z5j1rfwm6qvb-vm-test-run-codimd.drv' failed with exit code 1
error: build of '/nix/store/zchyqkb2l62rqm9wi5a4z5j1rfwm6qvb-vm-test-run-codimd.drv' failed

@Ma27
Copy link
Member

Ma27 commented Oct 10, 2018

Instead of specifying the patch which links to $PR (which breaks the package each time you update or force-push that branch) it might be better to reference the actual commit from your codimd fork.

@globin
Copy link
Member

globin commented Oct 10, 2018

Since it's merged it's fine like this.

@globin globin merged commit cf47423 into NixOS:master Oct 10, 2018
@WilliButz WilliButz deleted the update-codimd branch October 12, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilliButz @GrahamcOfBorg @Ma27 @globin