New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dwarf-fortress: fix build error #48074
Conversation
maybe also cherry-pick to 18.09 (no distribution is stable without dwarf-fortress ;)) |
pinging maintainers for review |
I would prefer that the latest version of the dwarf-fortress package (in master/unstable) gets merged because this has been fixed but apparently didn't make 18.09. TWBT and therapist will be broken in 18.09 too but work in unstable. |
BTW, can you try unstable and see if it works for you? |
unstable fails for me with: |
Oh, gotcha, misread the branch you were merging into. I know that there were some issues a while back, but there are apparently more now. I will test this in a couple hours, everything makes sense now. 👍 |
@GrahamcOfBorg build dwarf-fortress |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: dwarf-fortress Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dwarf-fortress Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: dwarf-fortress Partial log (click to expand)
|
Unfortunately I'm currently out of town on a slow connection, and didn't have an 18.09 system until this morning :( Changes look good though. Will give them a try tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Remind me if this isn't merged in a few days.
Thanks @matthewbauer! |
Motivation for this change
fix #46914
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)