Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwarf-fortress: fix build error #48074

Merged
merged 1 commit into from Oct 13, 2018
Merged

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Oct 8, 2018

Motivation for this change

fix #46914

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Lassulus Lassulus changed the title WIP: dwarf-fortress: fix build error dwarf-fortress: fix build error Oct 8, 2018
@Lassulus
Copy link
Member Author

Lassulus commented Oct 8, 2018

maybe also cherry-pick to 18.09 (no distribution is stable without dwarf-fortress ;))

@Lassulus
Copy link
Member Author

Lassulus commented Oct 8, 2018

pinging maintainers for review
@a1russell @robbinch @roconnor @the-kenny @abbradar @numinit

@numinit
Copy link
Contributor

numinit commented Oct 8, 2018

I would prefer that the latest version of the dwarf-fortress package (in master/unstable) gets merged because this has been fixed but apparently didn't make 18.09. TWBT and therapist will be broken in 18.09 too but work in unstable.

@numinit
Copy link
Contributor

numinit commented Oct 8, 2018

BTW, can you try unstable and see if it works for you?

@Lassulus
Copy link
Member Author

Lassulus commented Oct 8, 2018

unstable fails for me with: rm: cannot remove '/nix/store/w6ggm86nimcn4g2cmva3bsha8li24k5v-dwarf-fortress-env-0.44.12/data/init/init.txt': Permission denied

@numinit
Copy link
Contributor

numinit commented Oct 8, 2018

Oh, gotcha, misread the branch you were merging into. I know that there were some issues a while back, but there are apparently more now.

I will test this in a couple hours, everything makes sense now. 👍

@joachifm
Copy link
Contributor

joachifm commented Oct 9, 2018

@GrahamcOfBorg build dwarf-fortress

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: dwarf-fortress

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@numinit
Copy link
Contributor

numinit commented Oct 9, 2018

Unfortunately I'm currently out of town on a slow connection, and didn't have an 18.09 system until this morning :(

Changes look good though. Will give them a try tonight.

Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remind me if this isn't merged in a few days.

@numinit
Copy link
Contributor

numinit commented Oct 12, 2018

Thanks @matthewbauer!

@joachifm joachifm merged commit 0c7103b into NixOS:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build dwarf fortress 0.44.12
5 participants