Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md: add clarification on periods in commit messages #48076

Merged
merged 1 commit into from Oct 9, 2018
Merged

CONTRIBUTING.md: add clarification on periods in commit messages #48076

merged 1 commit into from Oct 9, 2018

Conversation

joncojonathan
Copy link
Member

Motivation for this change

Adds clarification for how to phrase the commit message.

Things done

Documentation change only.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edolstra edolstra merged commit 012cea9 into NixOS:master Oct 9, 2018
@vcunat
Copy link
Member

vcunat commented Oct 9, 2018

End of the first line of the commit message, but perhaps that's clear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joncojonathan @vcunat @edolstra @GrahamcOfBorg