helix-cli: init at 2018.1.1705517 #48091

nathyong · 2018-10-09T03:10:29Z

Motivation for this change

While the Perforce Visual Client (p4v) has already been packaged under that name, this change packages the accompanying command-line tools (p4).

The package name matches the convention that Perforce use for their own deb and rpm distributions (https://www.perforce.com/perforce/doc.current/manuals/p4sag/Content/P4SAG/install.linux.packages.install.html).

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

The Perforce client already exists under pkgs/applications/version-management/p4v/. This change packages the accompanying CLI utilities for Perforce, under the new name "Helix".

Enzime · 2018-10-09T05:11:41Z

@GrahamcOfBorg build helix-cli

GrahamcOfBorg · 2018-10-09T05:11:49Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: helix-cli

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-09T05:11:56Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: helix-cli

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

pkgs/applications/version-management/helix-cli/default.nix

@nlewo

Thanks to @nlewo and @lheckemann

pkgs/applications/version-management/helix-cli/default.nix

Resolved

ryantm

Please address comments from worldofpeace

Thanks to worldofpeace for the suggestions. Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>

Thanks to worldofpeace for the suggestions.

nathyong · 2019-07-01T02:32:19Z

Changes requested by worldofpeace should now be addressed.

worldofpeace · 2019-07-01T02:41:25Z

pkgs/applications/version-management/helix-cli/default.nix

+  };
+
+  dontBuild = true;
+  phases = [ "installPhase" ];


We want to deprecate explicitly setting phases.

Suggested change

phases = [ "installPhase" ];

This might cause an issue building so feel free to paste it.

stale · 2020-06-02T01:47:46Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

SuperSandro2000

Closing this because it is super old and no recent activity.

SuperSandro2000 · 2020-11-24T20:45:49Z

pkgs/applications/version-management/helix-cli/default.nix

+{ stdenv, fetchurl, patchelf }:
+
+stdenv.mkDerivation rec {
+  name = "helix-cli-${version}";


Suggested change

name = "helix-cli-${version}";

pname = "helix-cli";

helix-cli: init at 2018.1.1705517

5bb7cdc

The Perforce client already exists under pkgs/applications/version-management/p4v/. This change packages the accompanying CLI utilities for Perforce, under the new name "Helix".

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 9, 2018

nlewo previously requested changes Oct 13, 2018

View reviewed changes