Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex: grab simple upstream patch so it reports the right version #48088

Merged
merged 1 commit into from Oct 9, 2018
Merged

dex: grab simple upstream patch so it reports the right version #48088

merged 1 commit into from Oct 9, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 9, 2018

'dex --version' shows incorrect value, which may be misleading.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dex

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dex

Partial log (click to expand)

post-installation fixup
moving /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0/man to /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0
gzipping man pages under /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0/bin
patching script interpreter paths in /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0
/nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0/bin/dex: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0...
/nix/store/qf01gcylgdgxnqhy0q6jfnznjaaxlkyj-dex-0.8.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dex

Partial log (click to expand)

post-installation fixup
moving /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0/man to /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0
gzipping man pages under /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0/bin
patching script interpreter paths in /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0
/nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0/bin/dex: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0...
/nix/store/i5f3cr69n11rlxbpr4k4mhj7ni38g520-dex-0.8.0

@dtzWill dtzWill merged commit e8df98e into NixOS:master Oct 9, 2018
@dtzWill dtzWill deleted the fix/dex-version branch October 9, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg