ansible: Update to latest supported releases #48082
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
8.has: clean-up
8.has: package (new)
|
Looks good! Any chance this can get merged? |
|
@GrahamcOfBorg build ansible_2_5 ansible_2_6 ansible_2_7 |
c0bw3b
reviewed
Nov 1, 2018
| @@ -19,6 +19,10 @@ pythonPackages.buildPythonPackage rec { | |||
| patchShebangs bin/ansible-lint | |||
| ''; | |||
|
|
|||
| preBuild = '' | |||
| export HOME="$TMP" | |||
There was a problem hiding this comment.
not sure, see original PR message
|
(only known users can invoke the bot) Could you please split each updates in its own commit? Also for the removal of v2.4 : it needs to be documented in the release notes for 19.03 |
|
@GrahamcOfBorg build ansible_2_7 |
|
Success on x86_64-linux (full log) Attempted: ansible_2_7 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ansible_2_7 Partial log (click to expand)
|
|
@GrahamcOfBorg build ansible_2_6 |
|
Success on x86_64-linux (full log) Attempted: ansible_2_6 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ansible_2_6 Partial log (click to expand)
|
|
@GrahamcOfBorg build ansible_2_5 |
|
Success on aarch64-linux (full log) Attempted: ansible_2_5 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ansible_2_5 Partial log (click to expand)
|
|
@c0bw3b thanks for the recommendations, I'll update the PR. |
|
@GrahamcOfBorg build ansible_2_5 ansible_2_6 ansible_2_7 |
c0bw3b
added
the
1.severity: security
|
Success on x86_64-linux (full log) Attempted: ansible_2_5, ansible_2_6, ansible_2_7 Partial log (click to expand)
|
|
Security label because of CVE-2018-16837 |
|
Success on aarch64-linux (full log) Attempted: ansible_2_5, ansible_2_6, ansible_2_7 Partial log (click to expand)
|
|
Thank you @sengaya |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest supported ansible releases, see https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#release-status
Things done
removed ansible 2.4updated to latest minor release for 2.5 + 2.6
added ansible 2.7
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Fits CONTRIBUTING.md.
I had to add the
preBuildstep for ansible-lint because some tests failed duringnix-shell -p nox --run "nox-review wip". I don't really understand why this was no issue before this change.cc @jgeerds @joamaki