ansible: Update to latest supported releases #48082

sengaya · 2018-10-08T22:17:55Z

Motivation for this change

Update to latest supported ansible releases, see https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#release-status

Things done

~~removed ansible 2.4~~
updated to latest minor release for 2.5 + 2.6
added ansible 2.7
Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

I had to add the preBuild step for ansible-lint because some tests failed during nix-shell -p nox --run "nox-review wip". I don't really understand why this was no issue before this change.

cc @jgeerds @joamaki

dasJ · 2018-10-31T16:26:26Z

Looks good! Any chance this can get merged?

sengaya · 2018-11-01T20:51:38Z

@GrahamcOfBorg build ansible_2_5 ansible_2_6 ansible_2_7

c0bw3b · 2018-11-01T21:49:31Z

pkgs/development/tools/ansible-lint/default.nix

@@ -19,6 +19,10 @@ pythonPackages.buildPythonPackage rec {
    patchShebangs bin/ansible-lint
  '';

+   preBuild = ''
+     export HOME="$TMP"


Why is this needed?

not sure, see original PR message

c0bw3b · 2018-11-01T21:55:02Z

(only known users can invoke the bot)

Could you please split each updates in its own commit?
ansible_2_5: 2.5.2 -> 2.5.11
ansible_2_6: 2.6.2 -> 2.6.7
ansible_2_7: init at 2.7.1 in which you also do ansible2 = ansible_2_7
ansible_2_4: remove

Also for the removal of v2.4 : it needs to be documented in the release notes for 19.03
If you want the updates to be merged faster then maybe take v2.4 removal to a separate PR entirely

c0bw3b · 2018-11-01T21:55:25Z

@GrahamcOfBorg build ansible_2_7

GrahamcOfBorg · 2018-11-01T21:58:31Z

Success on x86_64-linux (full log)

Attempted: ansible_2_7

Partial log (click to expand)

wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-pull-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-vault-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-console-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-inventory-wrapped'...
/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1

GrahamcOfBorg · 2018-11-01T21:58:41Z

Success on aarch64-linux (full log)

Attempted: ansible_2_7

Partial log (click to expand)

wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-pull-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-inventory-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-console-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-config-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-wrapped'...
/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1

c0bw3b · 2018-11-01T22:02:28Z

@GrahamcOfBorg build ansible_2_6

GrahamcOfBorg · 2018-11-01T22:04:37Z

Success on x86_64-linux (full log)

Attempted: ansible_2_6

Partial log (click to expand)

wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-config-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-inventory-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-vault-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-console-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7/bin/.ansible-pull-wrapped'...
/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7

GrahamcOfBorg · 2018-11-01T22:05:27Z

Success on aarch64-linux (full log)

Attempted: ansible_2_6

Partial log (click to expand)

wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-pull-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-inventory-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-console-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-config-wrapped'...
wrapping `/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7/bin/.ansible-wrapped'...
/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7

c0bw3b · 2018-11-01T22:10:36Z

@GrahamcOfBorg build ansible_2_5

GrahamcOfBorg · 2018-11-01T22:12:12Z

Success on aarch64-linux (full log)

Attempted: ansible_2_5

Partial log (click to expand)

wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-pull-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-inventory-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-console-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-config-wrapped'...
wrapping `/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11/bin/.ansible-wrapped'...
/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11

GrahamcOfBorg · 2018-11-01T22:12:21Z

Success on x86_64-linux (full log)

Attempted: ansible_2_5

Partial log (click to expand)

wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-pull-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-vault-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-console-wrapped'...
wrapping `/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11/bin/.ansible-inventory-wrapped'...
/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11

sengaya · 2018-11-02T11:38:52Z

@c0bw3b thanks for the recommendations, I'll update the PR.

c0bw3b · 2018-11-03T15:05:35Z

@GrahamcOfBorg build ansible_2_5 ansible_2_6 ansible_2_7

GrahamcOfBorg · 2018-11-03T15:09:10Z

Success on x86_64-linux (full log)

Attempted: ansible_2_5, ansible_2_6, ansible_2_7

Partial log (click to expand)

wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-vault-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-playbook-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-console-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1/bin/.ansible-pull-wrapped'...
/nix/store/qkni6lggsp694w5wnngci12smr176sjg-python2.7-ansible-2.5.11
/nix/store/rfa6gwvl8dppcbf7vry0dvxm9q0xcvrj-python2.7-ansible-2.6.7
/nix/store/3ff65yi1l0hbr27bz0av0fb1mkwn3kjk-python2.7-ansible-2.7.1

c0bw3b · 2018-11-03T15:09:53Z

Security label because of CVE-2018-16837

GrahamcOfBorg · 2018-11-03T15:12:15Z

Success on aarch64-linux (full log)

Attempted: ansible_2_5, ansible_2_6, ansible_2_7

Partial log (click to expand)

wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-inventory-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-galaxy-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-doc-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-console-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-connection-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-config-wrapped'...
wrapping `/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1/bin/.ansible-wrapped'...
/nix/store/w0754jaq2zmnrmh22b3kwf7hvssk7l6d-python2.7-ansible-2.5.11
/nix/store/dkcy3y5vb4y3v1918y3iv6fv9ycbdn98-python2.7-ansible-2.6.7
/nix/store/dvjvnd39fd84wiakd2hcv9hhlc69jjcg-python2.7-ansible-2.7.1

c0bw3b · 2018-11-03T15:14:05Z

Thank you @sengaya

GrahamcOfBorg added 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 8, 2018

sengaya force-pushed the ansible-2.7 branch from b98b42f to 1cebbba Compare November 1, 2018 20:48

c0bw3b reviewed Nov 1, 2018

View reviewed changes

c0bw3b self-assigned this Nov 1, 2018

sengaya added 4 commits November 3, 2018 00:11

ansible_2_5: 2.5.2 -> 2.5.11

de8a3e3

ansible_2_6: 2.6.2 -> 2.6.7

e63509a

ansible_2_7: init at 2.7.1

c0d30e5

ansible-lint: fix install tests

a3739a9

sengaya force-pushed the ansible-2.7 branch from 1cebbba to a3739a9 Compare November 2, 2018 23:11

c0bw3b added the 1.severity: security label Nov 3, 2018

c0bw3b merged commit 78a6ee6 into NixOS:master Nov 3, 2018

c0bw3b mentioned this pull request Nov 3, 2018

[18.09] ansible: 2.5.2 -> 2.5.11 and 2.6.2 -> 2.6.7 #49697

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ansible: Update to latest supported releases #48082

ansible: Update to latest supported releases #48082

sengaya commented Oct 8, 2018 •

edited

dasJ commented Oct 31, 2018 •

edited

sengaya commented Nov 1, 2018

c0bw3b Nov 1, 2018

sengaya Nov 2, 2018

c0bw3b commented Nov 1, 2018 •

edited

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

sengaya commented Nov 2, 2018

c0bw3b commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

c0bw3b commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

c0bw3b commented Nov 3, 2018

ansible: Update to latest supported releases #48082

ansible: Update to latest supported releases #48082

Conversation

sengaya commented Oct 8, 2018 • edited

Motivation for this change

Things done

dasJ commented Oct 31, 2018 • edited

sengaya commented Nov 1, 2018

c0bw3b Nov 1, 2018

Choose a reason for hiding this comment

sengaya Nov 2, 2018

Choose a reason for hiding this comment

c0bw3b commented Nov 1, 2018 • edited

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

c0bw3b commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

GrahamcOfBorg commented Nov 1, 2018

sengaya commented Nov 2, 2018

c0bw3b commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

c0bw3b commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

c0bw3b commented Nov 3, 2018

sengaya commented Oct 8, 2018 •

edited

dasJ commented Oct 31, 2018 •

edited

c0bw3b commented Nov 1, 2018 •

edited