Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] gollum, jekyll (security backports) #47884

Merged
merged 3 commits into from Oct 4, 2018
Merged

[18.09] gollum, jekyll (security backports) #47884

merged 3 commits into from Oct 4, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@primeos
gollum: 4.1.2 -> 4.1.3
69d32c2 
(cherry picked from commit 265c5fc)
Reason: Security update: "Solves a vulnerability in the File view and
All Pages view that would allow XSS."
@primeos
jekyll: 3.8.3 -> 3.8.4 (security)
5ca268d 
(cherry picked from commit e8a3591)
Reason: Security update: "fix include bypass of EntryFilter#filter
symlink check".
@primeos
gollum: 4.1.3 -> 4.1.4 (security, CVE-2018-3740)
1f96d2f 
(cherry picked from commit 18b468e)
Reason: Security update: "Depend on new version of gollum-lib that
relies on a patched version of sanitize, which solves a vulnerability
(CVE-2018-3740). See gollum/gollum-lib#296."
@primeos primeos self-assigned this Oct 4, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/4zsqy0xkf87n8dp3xg7ilnnhgw1x65cj-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/contrib/sysv-debian/init.d/gollum: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/4zsqy0xkf87n8dp3xg7ilnnhgw1x65cj-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/bin/gollum: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/mci094h7wl3iwj2qcrhm86nf94j4dcgw-ruby-2.5.1/bin/ruby"
checking for references to /build in /nix/store/4zsqy0xkf87n8dp3xg7ilnnhgw1x65cj-ruby2.5.1-gollum-4.1.4...
building '/nix/store/5vyhr528g7x0dihwd4xn8m2b3vch6psl-gollum-4.1.4-gems.drv'...
created 103 symlinks in user environment
building '/nix/store/cfdnpwhz69bqw6861z6nxxpz6rg84hdb-gollum-4.1.4.drv'...
installing
/nix/store/l0xydyxqbay2r0ln8qh8iaf71d0ic9k5-gollum-4.1.4
/nix/store/mk8w2jv43b5dnihk7bsalnsjj1hfg8g3-jekyll-3.8.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

patching script interpreter paths in /nix/store/vbh9khakhvcp7fx4sp9xklqbh6k48bjs-ruby2.5.1-gollum-4.1.4
/nix/store/vbh9khakhvcp7fx4sp9xklqbh6k48bjs-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/bin/gollum: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/2nkqyb0i9i4wk8zwdfc0asd5n2qbnfnh-ruby-2.5.1/bin/ruby"
/nix/store/vbh9khakhvcp7fx4sp9xklqbh6k48bjs-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/contrib/sysv-debian/init.d/gollum: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
building '/nix/store/5m958nnp2jw0xjw4khc6l8crcqy0m6kr-gollum-4.1.4-gems.drv'...
created 103 symlinks in user environment
building '/nix/store/rcb8gx5jlsc7h5nag3caa1c5bcd3b3ji-gollum-4.1.4.drv'...
installing
/nix/store/1aphwwhzjf04sjd8x2scjdfldz22f2cd-gollum-4.1.4
/nix/store/fnyw8wpvkxgr8f63430w9ca3kw5gzi2p-jekyll-3.8.4

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: gollum, jekyll

Partial log (click to expand)

patching script interpreter paths in /nix/store/fq26vj02g60c0wjyy7fp6dr1jz6lfblk-ruby2.5.1-gollum-4.1.4
/nix/store/fq26vj02g60c0wjyy7fp6dr1jz6lfblk-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/bin/gollum: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/whp7b9fdn8z4iwn48w8fhlqjdnj1p9pl-ruby-2.5.1/bin/ruby"
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/fq26vj02g60c0wjyy7fp6dr1jz6lfblk-ruby2.5.1-gollum-4.1.4/lib/ruby/gems/2.5.0/gems/gollum-4.1.4/contrib/sysv-debian/init.d/gollum: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/fq26vj02g60c0wjyy7fp6dr1jz6lfblk-ruby2.5.1-gollum-4.1.4...
building '/nix/store/limdqfc18igmp4ydidwsxrh7429mcj6l-gollum-4.1.4-gems.drv'...
created 103 symlinks in user environment
building '/nix/store/b66rhfgi5gd623frz1nxra779ihpn891-gollum-4.1.4.drv'...
installing
error: build of '/nix/store/4lqm09g0a6yvhpx5d8d9hgl4k1fcjj2i-jekyll-3.8.4.drv' failed

@primeos
Copy link
Member Author

primeos commented Oct 4, 2018

Reason for the failure:

warning: unable to download 'https://cache.nixos.org/nar/19n3jvn8ya10p01lm2i4nlzi635509mw2sv6q0vh2zn6i6zc5rm1.nar.xz': HTTP error 503; retrying in 345 ms
error 7 while decompressing xz file

@primeos primeos merged commit cb08cb4 into NixOS:release-18.09 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @GrahamcOfBorg