Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luigi: init at 2.7.9 #47893

Merged
merged 1 commit into from Oct 13, 2018
Merged

luigi: init at 2.7.9 #47893

merged 1 commit into from Oct 13, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 5, 2018 •
edited

Motivation for this change

Batch job scheduler and runner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Oct 5, 2018

@GrahamcOfBorg build luigi

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/lib  /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-deps-tree'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi'...
/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/lib  /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps-tree'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/lib  /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps-tree'...

@bhipple
Copy link
Contributor Author

bhipple commented Oct 9, 2018

CC @FRidh I made the same change suggested in #47836 to just pass in pythonPackages for an application.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

installing
/build/luigi-2.7.9/dist /build/luigi-2.7.9
Processing ./luigi-2.7.9-py2-none-any.whl
Requirement already satisfied: python-daemon in /nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0/lib/python2.7/site-packages (from luigi==2.7.9) (2.2.0)
Requirement already satisfied: tornado<5,>=4.0 in /nix/store/z6ihj33wiizdf0lp51g2mzcsx56ckyxd-python2.7-tornado-4.5.3/lib/python2.7/site-packages (from luigi==2.7.9) (4.5.3)
Collecting enum34>1.1.0 (from luigi==2.7.9)
  Could not find a version that satisfies the requirement enum34>1.1.0 (from luigi==2.7.9) (from versions: )
No matching distribution found for enum34>1.1.0 (from luigi==2.7.9)
builder for '/nix/store/83y7gjv4q967rlmljhrrps8ivc1r75nk-luigi-2.7.9.drv' failed with exit code 1
error: build of '/nix/store/83y7gjv4q967rlmljhrrps8ivc1r75nk-luigi-2.7.9.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

installing
/build/luigi-2.7.9/dist /build/luigi-2.7.9
Processing ./luigi-2.7.9-py2-none-any.whl
Requirement already satisfied: python-daemon in /nix/store/764c2zdblmi4imf77l2wknxx92mv41mn-python2.7-python-daemon-2.2.0/lib/python2.7/site-packages (from luigi==2.7.9) (2.2.0)
Requirement already satisfied: tornado<5,>=4.0 in /nix/store/8ilqkn97r01q1xxzrr86bl14yhlj979g-python2.7-tornado-4.5.3/lib/python2.7/site-packages (from luigi==2.7.9) (4.5.3)
Collecting enum34>1.1.0 (from luigi==2.7.9)
  Could not find a version that satisfies the requirement enum34>1.1.0 (from luigi==2.7.9) (from versions: )
No matching distribution found for enum34>1.1.0 (from luigi==2.7.9)
builder for '/nix/store/nw0pwdy58p6w89wjz7imx9anf7rbl5py-luigi-2.7.9.drv' failed with exit code 1
error: build of '/nix/store/nw0pwdy58p6w89wjz7imx9anf7rbl5py-luigi-2.7.9.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/lib  /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-deps-tree'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9/bin/luigi'...
/nix/store/zgqz4alhs309b2m2ngl0nhdibyrx397k-luigi-2.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/lib  /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps-tree'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/kb0jjdpvi5qvzvb4l5f9w11ijvhj1ch0-luigi-2.7.9/bin/luigi-grep'...

FRidh
FRidh requested changes Oct 10, 2018
View reviewed changes
pkgs/applications/networking/cluster/luigi/default.nix Outdated
};

# Relax version constraint
patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postPatch so we can still pass in patches

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/lib  /nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9...
wrapping `/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin/luigi-deps-tree'...
wrapping `/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9/bin/luigi'...
/nix/store/aqz53a2r402gklpkq8xlcxnviid5376x-luigi-2.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/lib  /nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9
/nix/store/n698z0pvmzdzxc166ly7sf2afa5piyyy-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9...
wrapping `/nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin/luigi'...
wrapping `/nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/ik73wmif5svhb2cbv79g1kqaky7lsx8y-luigi-2.7.9/bin/luigi-deps-tree'...

@bhipple
Copy link
Contributor Author

bhipple commented Oct 13, 2018

Rebased and cleaned up the history, but no changes otherwise. This PR has a logical merge conflict with #47897, but I'll either update this one or the other one once one of them is merged (either order is OK with me).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: luigi

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/lib  /nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9
checking for references to /build in /nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9...
wrapping `/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin/luigi-deps-tree'...
wrapping `/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9/bin/luigi'...
/nix/store/nc53vijyhqq07z75vxiydwn2fz3c61vx-luigi-2.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: luigi

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/lib  /nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin
patching script interpreter paths in /nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9
checking for references to /build in /nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9...
wrapping `/nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin/luigi'...
wrapping `/nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin/luigi-grep'...
wrapping `/nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin/luigi-deps'...
wrapping `/nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin/luigid'...
wrapping `/nix/store/rgp1i8mv9id2rl7fvjjc5n9jkv6yqv1r-luigi-2.7.9/bin/luigi-deps-tree'...

@c0bw3b c0bw3b merged commit 0f5f873 into NixOS:master Oct 13, 2018
@bhipple bhipple deleted the add/luigi branch February 27, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @GrahamcOfBorg @FRidh @c0bw3b