kbd: Renamed norwegian dvorak keymap to dvorak-no. #47878
Conversation
|
There are quite a few duplicates: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kbd |
|
Do you mind adding those as well? |
|
Added the other map name changes. Should I put that into postPatch instead, by the way? I suppose that makes more sense, and if upstream ever changes you get the build error before compilation begins. |
|
Looks good. Can you change the branch from staging to master? This might require a rebase + force push on your site. |
plutotulp
force-pushed
the
kbd-dvorak-no
branch
2 times, most recently
from
d2a6ddc
to
d8d3f56
Compare
From upstream kbd, some keymap names are reused across very different keyboard layouts. This is a a problem because loadkeys just picks the first keymap it sees. The clashing names lead to e.g. "loadkeys no" defaulting to a norwegian dvorak map instead of the much more common qwerty one. Used Arch Linux's list of keymaps that need renaming, with a small deviation: the norwegian dvorak map becomes dvorak-no instead of no-dvorak, to match the naming scheme for all the other dvorak maps.
plutotulp
force-pushed
the
kbd-dvorak-no
branch
from
d8d3f56
to
c4c507d
Compare
|
Rebased to master, rewrote as a single commit on top of that, then force pushed. |
|
@plutotulp never mind I actually meant the opposite. Did you were on staging before. I will push it to staging now. I must have been confused. |
|
added in f1987fb the pull request will be closed automatically if staging is merged into master. |
|
At least I was able to test the pull request more easily on master. |
From upstream kbd, some keymap names are reused across very different keyboard layouts. This is a a problem because loadkeys just picks the first keymap it sees. The clashing names lead to e.g. "loadkeys no" defaulting to a norwegian dvorak map instead of the much more common qwerty one. Used Arch Linux's list of keymaps that need renaming, with a small deviation: the norwegian dvorak map becomes dvorak-no instead of no-dvorak, to match the naming scheme for all the other dvorak maps. fixes #47878 (cherry picked from commit f1987fb)
|
Also ported back to staging-18.09: df6d40f |
|
Great, thanks! |
This brings it in line with all the other dvorak map names, and keeps
it from hogging the "no" name from the qwery map.
Motivation for this change
Issue #47877; would get dvorak instead of qwerty keymap for "no" map.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)