Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.33.5 -> 0.33.6 #47880

Merged
merged 1 commit into from Oct 5, 2018
Merged

matrix-synapse: 0.33.5 -> 0.33.6 #47880

merged 1 commit into from Oct 5, 2018

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 4, 2018

Motivation for this change

Update to new release.
Changelog is here.

Built and tested manually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC package maintainers: @Ralith @roblabla @Ekleog

Ralith
Ralith approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ekleog
Copy link
Member

Ekleog commented Oct 5, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite: exit status 0
serverpostgres: running command: sync
serverpostgres: exit status 0
test script finished in 97.63s
cleaning up
killing serversqlite (pid 631)
killing serverpostgres (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ip96ykvdlznnwzwm5mg3ykq39h8fb6pf-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite: exit status 0
serverpostgres: running command: sync
serverpostgres: exit status 0
test script finished in 142.40s
cleaning up
killing serversqlite (pid 597)
killing serverpostgres (pid 608)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/smsbxqydxpf38hnc5sj71hikjxm3j21h-vm-test-run-matrix-synapse

Ekleog
Ekleog approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Needs backporting to 18.03 and 18.09 IMO :)

@srhb srhb merged commit 6540a48 into NixOS:master Oct 5, 2018
srhb pushed a commit that referenced this pull request Oct 5, 2018
@pacien @srhb
matrix-synapse: 0.33.5 -> 0.33.6
4e73b76 
(cherry picked from commit 570b9ba)
Backport of #47880
@srhb
Copy link
Contributor

srhb commented Oct 5, 2018

@Ekleog #47880 was not backported to 18.03 as far as I can see. If that was intentional, then I don't think this should be either.

@Ekleog
Copy link
Member

Ekleog commented Oct 5, 2018

@srhb Thank you for the merge and backport to 18.09!

For 18.03, I guess you wanted to link #47273 ?

Then you're right, it has not been backported to 18.03… I think because no one requested it? At least it wasn't a conscious choice from me :) Currently 18.03 is at 0.33.3.1 (so ready to accept #47273), and both PRs are bugfix release whose only potential backwards-compat changes are changes to the log format, which I guess we can safely break.

So I'd be in favor of backporting both this and #47273 to 18.03. @Ralith @Mic92, any opinions on that?

@srhb
Copy link
Contributor

srhb commented Oct 5, 2018 •
edited

For 18.03, I guess you wanted to link #47273 ?

Oops, yes, thank you. :)

@Ralith
Copy link
Contributor

Ralith commented Oct 5, 2018

FWIW, versions newer than 0.33.3.1 break on my deployment (see matrix-org/synapse#3981). They're certainly not intended to be breaking, of course.

@Ekleog
Copy link
Member

Ekleog commented Oct 5, 2018

Well, I guess this will not happen, then. :)

Stupid question, but: would you be able to make a NixOS test that fails with the versions newer than 0.33.3.1? This would make future detection of similar issues much easier. Then maybe leave it disabled by default in the test suite, so that we can merge future updates until this test is fixed?

@Ralith
Copy link
Contributor

Ralith commented Oct 5, 2018

I'm not sure if issue is easily reproducible; I certainly don't expect that it affects all NixOS synapse deployments. Still waiting to hear how upstream's investigation goes.

@Mic92
Copy link
Member

Mic92 commented Oct 10, 2018

I would this decision whether to backport up to maintainers of synapses package.

@Ralith
Copy link
Contributor

Ralith commented Oct 10, 2018

0.33.6 seems to work fine, so I do not oppose a backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacien @Ekleog @GrahamcOfBorg @srhb @Ralith @Mic92