Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dpath: init at 1.4.2 #47887

Merged
merged 1 commit into from Nov 12, 2018
Merged

pythonPackages.dpath: init at 1.4.2 #47887

merged 1 commit into from Nov 12, 2018

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Oct 4, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mmlb mmlb requested a review from FRidh as a code owner October 4, 2018 20:08
@bhipple
Copy link
Contributor

bhipple commented Oct 5, 2018

@GrahamcOfBorg build python2Packages.dpath python3Packages.dpath

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

reading manifest file 'dpath.egg-info/SOURCES.txt'
writing manifest file 'dpath.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/wzs0n6k7r0v8qwjrz431wkmx2sp2h4h0-python2.7-dpath-1.4.2
/nix/store/fsc5hdfcinp2q43syqz598g9jzkm3mw9-python3.6-dpath-1.4.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

reading manifest file 'dpath.egg-info/SOURCES.txt'
writing manifest file 'dpath.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/18s44ffama1v5qdxawnfvp7g2h0gfd31-python2.7-dpath-1.4.2
/nix/store/3h97v71p7ig38jfdwyabkn80kadmgxnd-python3.6-dpath-1.4.2

@bhipple
Copy link
Contributor

bhipple commented Oct 5, 2018

It looks like upstream also has some tests, which you can run with nosetests.

@mmlb
Copy link
Contributor Author

mmlb commented Oct 5, 2018

@bhipple fixed up, ptal.

@bhipple
Copy link
Contributor

bhipple commented Oct 7, 2018

@GrahamcOfBorg build python2Packages.dpath python3Packages.dpath

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)


OK
running install tests
.................................................
----------------------------------------------------------------------
Ran 49 tests in 0.078s

OK
/nix/store/0sbvvfq5mf217y7m4qmgxjmypq5cc4p9-python2.7-dpath-1.4.2
/nix/store/n374mzc6vcn50r9dfvrrpw4nqx50qlvk-python3.6-dpath-1.4.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

patching script interpreter paths in /nix/store/5glxv269v9klqs44ncs80vr5wdgjp649-python3.6-dpath-1.4.2
checking for references to /build in /nix/store/5glxv269v9klqs44ncs80vr5wdgjp649-python3.6-dpath-1.4.2...
running install tests
.................................................
----------------------------------------------------------------------
Ran 49 tests in 0.148s

OK
/nix/store/iqkjix2psipqyk451f9bczgs5lx3cby8-python2.7-dpath-1.4.2
/nix/store/5glxv269v9klqs44ncs80vr5wdgjp649-python3.6-dpath-1.4.2

@mmlb
Copy link
Contributor Author

mmlb commented Oct 16, 2018

ping @bhipple

@mmlb
Copy link
Contributor Author

mmlb commented Oct 16, 2018

and @FRidh

@samueldr
Copy link
Member

Let's have a last ofborg build, since there was a push since the last builds, as a formality. From here, everything looks good IMHO.

@GrahamcOfBorg build python2Packages.dpath python3Packages.dpath

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

Ran 49 tests in 0.051s

OK
.................................................
----------------------------------------------------------------------
Ran 49 tests in 0.048s

OK
/nix/store/7byzrz8wvb4mxq9av1xmzvh3hr9jv4n2-python2.7-dpath-1.4.2
/nix/store/k0znjw27b01jf94n34jdd5zmr9pb8ri4-python3.6-dpath-1.4.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

patching script interpreter paths in /nix/store/943y73p1yx3q0h5y6gcd6hax1n3y1xc3-python3.6-dpath-1.4.2
checking for references to /build in /nix/store/943y73p1yx3q0h5y6gcd6hax1n3y1xc3-python3.6-dpath-1.4.2...
running install tests
.................................................
----------------------------------------------------------------------
Ran 49 tests in 0.113s

OK
/nix/store/vinaxmlq3zz6qzp4l67filx31ikmnd38-python2.7-dpath-1.4.2
/nix/store/943y73p1yx3q0h5y6gcd6hax1n3y1xc3-python3.6-dpath-1.4.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.dpath, python3Packages.dpath

Partial log (click to expand)

patching script interpreter paths in /nix/store/9xc5i5jkrj1cx0bd84n9272l3il6p03k-python2.7-dpath-1.4.2
checking for references to /build in /nix/store/9xc5i5jkrj1cx0bd84n9272l3il6p03k-python2.7-dpath-1.4.2...
running install tests
.................................................
----------------------------------------------------------------------
Ran 49 tests in 0.068s

OK
/nix/store/9xc5i5jkrj1cx0bd84n9272l3il6p03k-python2.7-dpath-1.4.2
/nix/store/ycai7ijijaksj1pyc5952y88sqcpjcik-python3.6-dpath-1.4.2

@samueldr samueldr merged commit 242282d into NixOS:master Nov 12, 2018
@mmlb
Copy link
Contributor Author

mmlb commented Nov 15, 2018

👍

@mmlb mmlb deleted the python-dpath branch November 15, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmlb @bhipple @GrahamcOfBorg @samueldr