Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpdf: Fix URL of CVE-2018-9918.patch #47899

Closed
wants to merge 1 commit into from
Closed

qpdf: Fix URL of CVE-2018-9918.patch #47899

wants to merge 1 commit into from

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 5, 2018

Motivation for this change

To fix the build. Previously this pointed to GitHub's HTML rendering.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bgamari
qpdf: Fix URL of CVE-2018-9918.patch
1580261 
Previously this pointed to GitHub's HTML rendering.
@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

Thanks for spotting this. I don't understand how it ever built with the wrong patch url...
@GrahamcOfBorg build qpdf

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qpdf

Partial log (click to expand)

Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file qpdf/qtest/qpdf/issue-146.out.rej
The next patch would create the file qpdf/qtest/qpdf/issue-202.out,
which already exists!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
builder for '/nix/store/g07hmn9k0wbm47bshvrmd1c0va1jyx11-qpdf-8.2.1.drv' failed with exit code 1
error: build of '/nix/store/g07hmn9k0wbm47bshvrmd1c0va1jyx11-qpdf-8.2.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: qpdf

Partial log (click to expand)

Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file qpdf/qtest/qpdf/issue-146.out.rej
The next patch would create the file qpdf/qtest/qpdf/issue-202.out,
which already exists!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
builder for '/nix/store/4v7lfisry1s6f9362cmhzipg3dnmbzfk-qpdf-8.2.1.drv' failed with exit code 1
error: build of '/nix/store/4v7lfisry1s6f9362cmhzipg3dnmbzfk-qpdf-8.2.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: qpdf

Partial log (click to expand)

Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file qpdf/qtest/qpdf/issue-146.out.rej
The next patch would create the file qpdf/qtest/qpdf/issue-202.out,
which already exists!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
builder for '/nix/store/4cdnak5j7wim4f0fn29acfniab366v27-qpdf-8.2.1.drv' failed with exit code 1
error: build of '/nix/store/4cdnak5j7wim4f0fn29acfniab366v27-qpdf-8.2.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

Looks like the patch has already been applied upstream in the current version, please check. If this is the case, please remove the patch.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 5, 2018

Yes the content of the patch is already present in v8.2.1

@bgamari bgamari mentioned this pull request Oct 5, 2018
Merged
9 tasks
@bgamari
Copy link
Contributor Author

bgamari commented Oct 5, 2018

Closing in favor of #47935.

@bgamari bgamari closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @xeji @GrahamcOfBorg @c0bw3b