Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.eradicate: init at 0.2.1 #47894

Closed
wants to merge 1 commit into from
Closed

pythonPackages.eradicate: init at 0.2.1 #47894

wants to merge 1 commit into from

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Oct 5, 2018

Motivation for this change

This is a new dependency of pylama, which I intend to PR with the upgrade.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mmlb mmlb requested a review from FRidh as a code owner October 5, 2018 01:35
@mmlb mmlb mentioned this pull request Oct 5, 2018
Merged
9 tasks
@mmlb mmlb changed the title pythonPackages.eradicatge: init at 0.2.1 pythonPackages.eradicate: init at 0.2.1 Oct 5, 2018
@mmlb
Copy link
Contributor Author

mmlb commented Oct 5, 2018

I wanted to run python test_eradicate.py but the file is not available during checkPhase as its not packaged by distutils, any idea how I can run the test?

@FRidh
Copy link
Member

FRidh commented Oct 9, 2018

You mean the script is in the tarball, but not installed into $out? That is often the case. You can still point to the source folder.

@mmlb
Copy link
Contributor Author

mmlb commented Oct 10, 2018

oops so I was mistaken. I thought for some reason I was fetching source from github where the test file lies, but its actually coming from pypi where its never packaged. So I think this is about as good as can be and is ready @FRidh

nlewo
nlewo requested changes Oct 12, 2018
View reviewed changes
pkgs/development/python-modules/eradicate/default.nix
};

meta = with lib; {
description = "eradicate removes commented-out code from Python files.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize the first letter and remove the last ..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, I missed it.

pkgs/development/python-modules/eradicate/default.nix
description = "eradicate removes commented-out code from Python files.";
homepage = https://github.com/myint/eradicate;
license = [ licenses.mit ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) useless blank line

@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

This package has been merged (80651cf)

@FRidh FRidh closed this Oct 13, 2018
@mmlb
Copy link
Contributor Author

mmlb commented Oct 16, 2018

oops didn't see the comments by @nlewo sorry.

@mmlb mmlb deleted the python-eradicate branch October 16, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmlb @FRidh @nlewo @GrahamcOfBorg