ghostscript: fix icc profile validation #47903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
commented
Oct 5, 2018
| @@ -46,6 +46,7 @@ stdenv.mkDerivation rec { | |||
| patches = [ | |||
| ./urw-font-files.patch | |||
| ./doc-no-ref.diff | |||
| ./0001-For-ICC-profile-validation-have-cups-id-iteself-as-D.patch | |||
There was a problem hiding this comment.
I didn't use fetchpatch, as the source url http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=bc3df0773fcc caused problems.
There was a problem hiding this comment.
Add the source url in the commit message and state that it must be included into nixpkgs due to invalid characters.
|
I didn't check whether unstable is affected too, as switching there took to long for me (but guess it is). As there are some scary fixes on master anyhow, I assume we should bump to 9.26 as soon as it's released on both channels anyhow, but I didn't want to introduce a printing regression in 18.09 |
|
Success on aarch64-linux (full log) Attempted: ghostscript Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ghostscript Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ghostscript Partial log (click to expand)
|
flokli
force-pushed
the
ghostscript-icc-profile-validation
branch
from
b383f32
to
5aea394
Compare
flokli
requested review from
basvandijk,
edwtjo,
nbp,
peti and
ryantm
as code owners
Currently, printing color documents fails with the following error: Oct 05 08:34:21 tp cupsd[16855]: | ./base/gsicc_manage.c:1863: gsicc_verify_device_profiles(): Mismatch of ICC profiles and device color model Oct 05 08:34:21 tp cupsd[16855]: | ./base/gsicc_manage.c:1990: gsicc_set_device_profile(): Error in device profiles Oct 05 08:34:21 tp cupsd[16855]: Unrecoverable error: rangecheck in .putdeviceprops Add the corresponding patch from ghostscript master to fix this
flokli
force-pushed
the
ghostscript-icc-profile-validation
branch
from
5aea394
to
df4456a
Compare
|
Success on aarch64-linux (full log) Attempted: ghostscript Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ghostscript Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ghostscript Partial log (click to expand)
|
peti
reviewed
Oct 5, 2018
|
duplicate of #46216. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, printing color documents fails with the following error:
Add the corresponding patch from ghostscript master to fix this.
Motivation for this change
Printing color documents didn't work on my printer (HP Officejet 4620). With this patch, it works again.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)