Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/emby: fixes binary name change introduced by #47659 #47906

Merged
merged 1 commit into from Oct 5, 2018
Merged

nixos/emby: fixes binary name change introduced by #47659 #47906

merged 1 commit into from Oct 5, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Oct 5, 2018 •
edited

Motivation for this change

The previous pull request I made (#47659) introduced a change in the binary name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member Author

cc @timokau

@timokau timokau merged commit 3f98dd1 into NixOS:master Oct 5, 2018
@timokau
Copy link
Member

timokau commented Oct 5, 2018

I have taken the liberty to rephrase the commit message to be

  • written in the imperative (as is standard)
  • be a bit more descriptive

Thank you for the fix :)

@nyanloutre nyanloutre deleted the emby-bin-name-fix branch October 22, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @timokau @GrahamcOfBorg