Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pythondaemon: rename to pythonPackages.python-daemon #47897

Merged
merged 1 commit into from Oct 30, 2018
Merged

pythonPackages.pythondaemon: rename to pythonPackages.python-daemon #47897

merged 1 commit into from Oct 30, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 5, 2018 •
edited

This commit renames the pythondaemon module to match its module name, github
name, and pypi name, which makes it easier to find and reference. In order to
avoid breaking any external users, I've left an alias with a deprecated warning.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner October 5, 2018 01:53
@bhipple
Copy link
Contributor Author

bhipple commented Oct 5, 2018

@GrahamcOfBorg build pythonPackages.python-daemon pythonPackages.pythondaemon

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.python-daemon, pythonPackages.pythondaemon

Partial log (click to expand)

trace: DEPRECATED: pythondaemon has been renamed to python-daemon
these paths will be fetched (0.03 MiB download, 0.18 MiB unpacked):
  /nix/store/764c2zdblmi4imf77l2wknxx92mv41mn-python2.7-python-daemon-2.2.0
  /nix/store/cvfaw2vckl4yl8ifdiqxz4z2p4ykj1yi-python2.7-lockfile-0.12.2
copying path '/nix/store/cvfaw2vckl4yl8ifdiqxz4z2p4ykj1yi-python2.7-lockfile-0.12.2' from 'https://cache.nixos.org'...
copying path '/nix/store/764c2zdblmi4imf77l2wknxx92mv41mn-python2.7-python-daemon-2.2.0' from 'https://cache.nixos.org'...
/nix/store/764c2zdblmi4imf77l2wknxx92mv41mn-python2.7-python-daemon-2.2.0
/nix/store/764c2zdblmi4imf77l2wknxx92mv41mn-python2.7-python-daemon-2.2.0

@bhipple
Copy link
Contributor Author

bhipple commented Oct 5, 2018 •
edited

@FRidh what do we think about these kinds of refactorings and using the trace function to leave a deprecated warning? I think python-daemon is a much better name for this, since it matches the module and pypi names.

λ brh nixpkgs →  nix-build . -A pythonPackages.python-daemon
/nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0

λ brh nixpkgs →  nix-build . -A pythonPackages.pythondaemon
trace: DEPRECATED: pythondaemon has been renamed to python-daemon
/nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0

I see a handful of inconsistently named python packages, and if it's not too much hassle would like to update some of them to accurately reflect their module names.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.python-daemon, pythonPackages.pythondaemon

Partial log (click to expand)

trace: DEPRECATED: pythondaemon has been renamed to python-daemon
these paths will be fetched (0.03 MiB download, 0.18 MiB unpacked):
  /nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0
  /nix/store/iyjw573c6s4cxnd9g9fy62a1g2ymnqhq-python2.7-lockfile-0.12.2
copying path '/nix/store/iyjw573c6s4cxnd9g9fy62a1g2ymnqhq-python2.7-lockfile-0.12.2' from 'https://cache.nixos.org'...
copying path '/nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0' from 'https://cache.nixos.org'...
/nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0
/nix/store/bc4lr49nw788g83zmnbma99iiz6rqv6z-python2.7-python-daemon-2.2.0

@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

Ideally we use the normalized names here in python-packages.nix. Doing a renaming can break things so the question is whether it is worth it. The same with using an alias.

This is a very uncommon package, so just do the rename, and drop the alias.

@bhipple
Copy link
Contributor Author

bhipple commented Oct 13, 2018

Ok sounds good; I'll just rename it then. Thanks!

@bhipple bhipple mentioned this pull request Oct 13, 2018
Merged
9 tasks
@bhipple
pythonPackages.pythondaemon: rename to pythonPackages.python-daemon
3613c85 
This commit renames the pythondaemon module to match its module name, github
name, and pypi name, which makes it easier to find and reference. In order to
avoid breaking any external users, I've left an alias with a deprecated warning.
@bhipple
Copy link
Contributor Author

bhipple commented Oct 15, 2018

Rebased and updated for luigi as well.

@GrahamcOfBorg build python2Packages.python-daemon python3Packages.python-daemon luigi pythonPackages.libagent

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.python-daemon, python3Packages.python-daemon, luigi, pythonPackages.libagent

Partial log (click to expand)

copying path '/nix/store/z1y6j08ip7f2bc4cas2v3g873f2jkisn-python3.6-tornado-4.5.3' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/0ipim1a49minsrilja1srd1x6jqxbpi2-tk-8.6.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/i0m603iz7lpa5wwy7ry3k9jqc3asy09i-luigi-2.7.9' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/zrkbg61wj2p4d5l848b7q4qxg4pq6q0x-python2.7-tkinter-2.7.15' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/pgdndlj8b0lzsfw9g16sdvnc2b2yr688-python2.7-PyMsgBox-1.0.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/8w57hjnxgwwi2dz2lys4h9vlxmcl1fhw-python2.7-libagent-0.12.0' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/zlg6aymfndlxvlb8xf5yxpr6fj5nkalp-python2.7-python-daemon-2.2.0
/nix/store/ii13nm0g8294wnmhi35c8nv5y5ls2pi7-python3.6-python-daemon-2.2.0
/nix/store/i0m603iz7lpa5wwy7ry3k9jqc3asy09i-luigi-2.7.9
/nix/store/8w57hjnxgwwi2dz2lys4h9vlxmcl1fhw-python2.7-libagent-0.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.python-daemon, python3Packages.python-daemon, luigi, pythonPackages.libagent

Partial log (click to expand)

copying path '/nix/store/grks8iwfpkgvn8mi8bb4f2c8fklab2z7-python2.7-PyMsgBox-1.0.6' from 'https://cache.nixos.org'...
copying path '/nix/store/m1wjla00k4wpsvnq4p67yi3gdkgw4lxc-python2.7-python-daemon-2.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/1mykx1l6mmpql2jac7yn694p0w57vzmw-python2.7-mnemonic-0.18' from 'https://cache.nixos.org'...
copying path '/nix/store/ddlyjz91xyq4kiy4kbg2jmxfi9c798sb-python3.6-python-daemon-2.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/l8r81zxiny241qfwh46r28ky5lh94zr3-python2.7-libagent-0.12.0' from 'https://cache.nixos.org'...
copying path '/nix/store/mb56m5f8h0kwapdc6ha0yad2y6vvmd5q-luigi-2.7.9' from 'https://cache.nixos.org'...
/nix/store/m1wjla00k4wpsvnq4p67yi3gdkgw4lxc-python2.7-python-daemon-2.2.0
/nix/store/ddlyjz91xyq4kiy4kbg2jmxfi9c798sb-python3.6-python-daemon-2.2.0
/nix/store/mb56m5f8h0kwapdc6ha0yad2y6vvmd5q-luigi-2.7.9
/nix/store/l8r81zxiny241qfwh46r28ky5lh94zr3-python2.7-libagent-0.12.0

@bhipple
Copy link
Contributor Author

bhipple commented Oct 22, 2018

Ping @FRidh? This should still be good to go, and I think it cleans up a little tech debt at little cost given ti's a relatively rare module.

@bhipple bhipple mentioned this pull request Oct 22, 2018
Closed
9 tasks
@FRidh FRidh merged commit baf0703 into NixOS:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @FRidh