Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5200167f125a
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a363ed107184
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 4, 2018

  1. arrow-cpp: 0.9.0 -> 0.10.0

    pythonPackages.pyarrow: 0.9.0 -> 0.10.0
    parquet: 1.4.0 -> 1.5.0
    veprbl committed Oct 4, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    zimbatm Jonas Chevalier
    Copy the full SHA
    3942226 View commit details
  2. Merge pull request #47832 from veprbl/pr/arrow_0.10.0

    arrow-cpp: 0.9.0 -> 0.10.0
    Mic92 authored Oct 4, 2018
    Copy the full SHA
    a363ed1 View commit details
11 changes: 11 additions & 0 deletions pkgs/development/libraries/arrow-cpp/darwin.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
diff --git a/cmake_modules/FindPythonLibsNew.cmake b/cmake_modules/FindPythonLibsNew.cmake
--- a/cmake_modules/FindPythonLibsNew.cmake
+++ b/cmake_modules/FindPythonLibsNew.cmake
@@ -117,6 +117,7 @@ list(GET _PYTHON_VALUES 6 PYTHON_SIZEOF_VOID_P)
list(GET _PYTHON_VALUES 7 PYTHON_LIBRARY_SUFFIX)
list(GET _PYTHON_VALUES 8 PYTHON_LIBRARY_PATH)
list(GET _PYTHON_VALUES 9 PYTHON_OTHER_LIBS)
+string(REPLACE "-lncurses" "" PYTHON_OTHER_LIBS "${PYTHON_OTHER_LIBS}")

# Make sure the Python has the same pointer-size as the chosen compiler
# Skip the check on OS X, it doesn't consistently have CMAKE_SIZEOF_VOID_P defined
7 changes: 5 additions & 2 deletions pkgs/development/libraries/arrow-cpp/default.nix
Original file line number Diff line number Diff line change
@@ -2,15 +2,18 @@

stdenv.mkDerivation rec {
name = "arrow-cpp-${version}";
version = "0.9.0";
version = "0.10.0";

src = fetchurl {
url = "mirror://apache/arrow/arrow-${version}/apache-arrow-${version}.tar.gz";
sha256 = "16l91fixb5dgx3v6xc73ipn1w1hjgbmijyvs81j7ywzpna2cdcdy";
sha256 = "0bc4krapz1kzdm16npzmgdz7zvg9lip6rnqbwph8vfn7zji0fcll";
};

sourceRoot = "apache-arrow-${version}/cpp";

# patch to fix python-test
patches = [ ./darwin.patch ];

nativeBuildInputs = [ cmake ];
buildInputs = [ boost python.pkgs.python python.pkgs.numpy ];

12 changes: 12 additions & 0 deletions pkgs/development/libraries/parquet-cpp/api.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/src/parquet/arrow/reader.cc b/src/parquet/arrow/reader.cc
--- a/src/parquet/arrow/reader.cc
+++ b/src/parquet/arrow/reader.cc
@@ -1421,7 +1421,7 @@ Status StructImpl::DefLevelsToNullArray(std::shared_ptr<Buffer>* null_bitmap_out
const int16_t* def_levels_data;
size_t def_levels_length;
RETURN_NOT_OK(GetDefLevels(&def_levels_data, &def_levels_length));
- RETURN_NOT_OK(AllocateEmptyBitmap(pool_, def_levels_length, &null_bitmap));
+ RETURN_NOT_OK(GetEmptyBitmap(pool_, def_levels_length, &null_bitmap));
uint8_t* null_bitmap_ptr = null_bitmap->mutable_data();
for (size_t i = 0; i < def_levels_length; i++) {
if (def_levels_data[i] < struct_def_level_) {
6 changes: 4 additions & 2 deletions pkgs/development/libraries/parquet-cpp/default.nix
Original file line number Diff line number Diff line change
@@ -2,13 +2,15 @@

stdenv.mkDerivation rec {
name = "parquet-cpp-${version}";
version = "1.4.0";
version = "1.5.0";

src = fetchurl {
url = "https://github.com/apache/parquet-cpp/archive/apache-${name}.tar.gz";
sha256 = "1kn7pjzi5san5f05qbl8l8znqsa3f9cq9bflfr4s2jfwr7k9p2aj";
sha256 = "19nwqahc0igr0jfprbf2m86rmzz6zicw4z7b8z832wbsyc904wli";
};

patches = [ ./api.patch ];

nativeBuildInputs = [ cmake ];
buildInputs = [ boost ];

10 changes: 3 additions & 7 deletions pkgs/development/python-modules/pyarrow/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, buildPythonPackage, python, isPy3k, fetchurl, arrow-cpp, cmake, cython, futures, numpy, pandas, pytest, pytestrunner, parquet-cpp, pkgconfig, setuptools_scm, six }:
{ lib, buildPythonPackage, python, isPy3k, fetchurl, arrow-cpp, cmake, cython, futures, JPype1, numpy, pandas, pytest, pytestrunner, parquet-cpp, pkgconfig, setuptools_scm, six }:

let
_arrow-cpp = arrow-cpp.override { inherit python;};
@@ -7,18 +7,14 @@ in

buildPythonPackage rec {
pname = "pyarrow";
version = "0.9.0";

src = fetchurl {
url = "mirror://apache/arrow/arrow-${version}/apache-arrow-${version}.tar.gz";
sha256 = "16l91fixb5dgx3v6xc73ipn1w1hjgbmijyvs81j7ywzpna2cdcdy";
};
inherit (_arrow-cpp) version src;

sourceRoot = "apache-arrow-${version}/python";

nativeBuildInputs = [ cmake cython pkgconfig setuptools_scm ];
propagatedBuildInputs = [ numpy six ] ++ lib.optionals (!isPy3k) [ futures ];
checkInputs = [ pandas pytest pytestrunner ];
checkInputs = [ pandas pytest pytestrunner JPype1 ];

PYARROW_BUILD_TYPE = "release";
PYARROW_CMAKE_OPTIONS = "-DCMAKE_INSTALL_RPATH=${ARROW_HOME}/lib;${PARQUET_HOME}/lib";