Package modem-manager-gui #48959

alesya-h · 2018-10-24T06:23:15Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

pkgs/applications/networking/modem-manager-gui/default.nix

jtojnar · 2018-10-24T12:04:13Z

pkgs/applications/networking/modem-manager-gui/default.nix

+
+  buildInputs = [
+    pkgconfig
+    gtk3-x11


Why not just gtk3?

I didn't knew it existed - nix-env -f "<nixpkgs>" -qaP|grep gtk3 doesn't list gtk3, only gtk3-x11. Is there a command that would have listed gtk3?

I would use nix-index’s nix-locate. It is available on IRC as well, as ,locale libgtk-3 command, but it suffers from the same problem – Nix does not know which attribute path is canonical. Grepping nixpkgs source code is still the best way, IMHO.

jtojnar · 2018-10-24T12:15:42Z

pkgs/applications/networking/modem-manager-gui/default.nix

+  };
+
+  buildInputs = [
+    pkgconfig


Programs executed during build should go to nativeBuildInputs.

jtojnar · 2018-10-24T12:22:32Z

pkgs/applications/networking/modem-manager-gui/default.nix

+  ];
+
+  preConfigure = ''
+    sed -i 's|! test -e "/usr/include/gdbm/gdbm.h"|false|' configure


Could you create a patch file instead? sed calls get outdated pretty fast without any warning.

jtojnar · 2018-10-24T12:53:26Z

pkgs/applications/networking/modem-manager-gui/default.nix

+    sha256 = "04p08gzvi068bd3slbnaghajwzp4h5jacib640k5shngqimkl84p";
+  };
+
+  buildInputs = [


It seems you forgot to add meson to nativeBuildInputs.

Even though meson and ninja are specified on the project page, it also builds with just ./configure and make. I tried to make it work with meson, but for some reason it turned out to be much harder.

Meson is the preferred build system. What issues are you encountering specifically?

... Build targets in project: 24 Found ninja-1.8.2 at /nix/store/35wvn5g0igx8xpqzm66j3anpi0icy6rg-ninja-1.8.2/bin/ninja meson: enabled parallel building building build flags: -j1 -l1 [1/66] Generating modem-manager-gui.appdata.xml_merge with a custom command. [2/66] Generating modem-manager-gui.desktop_merge with a custom command. [3/66] Generating man-de with a custom command. FAILED: man/de/modem-manager-gui.1.gz /build/hg-archive/man/manhelper.py ../man/de/de.po man/de/modem-manager-gui.1.gz /bin/sh: /build/hg-archive/man/manhelper.py: not found ninja: build stopped: subcommand failed. builder for '/nix/store/jnn4w26z9z13kqgij31s0mw0y1p8p2m0-modem-manager-gui.drv' failed with exit code 1

It cannot find the /usr/bin/env in the shebang of the script You will need to do

postPatch = '' patchShebangs man/manhelper.py '';

possibly preceded by chmod +xing the file.

manhelper.py is already executable, so it worked without chmod, but then the script itself failed:

meson: enabled parallel building building build flags: -j1 -l1 [1/66] Generating modem-manager-gui.appdata.xml_merge with a custom command. [2/66] Generating modem-manager-gui.desktop_merge with a custom command. [3/66] Generating man-de with a custom command. FAILED: man/de/modem-manager-gui.1.gz /build/hg-archive/man/manhelper.py ../man/de/de.po man/de/modem-manager-gui.1.gz Traceback (most recent call last): File "/build/hg-archive/man/manhelper.py", line 20, in <module> for line in intfile: File "/nix/store/nrl0l79a48924xb0897ap572xf29ciir-python3-3.6.6/lib/python3.6/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 363: ordinal not in range(128) ninja: build stopped: subcommand failed. builder for '/nix/store/v9v1sbnpr6xazzp8qrr98yb32wnpmyi9-modem-manager-gui.drv' failed with exit code 1

It is one of issues with our python. You can fix it by adding LC_ALL = "en_US.utf-8" attribute to the derivation and glibcLocales to nativeBuildInputs.

That worked. Updated the package to build with meson and ninja.

jtojnar · 2018-10-25T03:59:21Z

pkgs/applications/networking/modem-manager-gui/default.nix

+    gdbm
+    gtkspell3
+
+    itstool


itstool belongs to nativeBuildInputs

jtojnar · 2018-10-25T05:59:03Z

pkgs/applications/networking/modem-manager-gui/remove-fhs-gdbm-check.patch

@@ -0,0 +1,16 @@
+--- a/configure	2018-10-25 14:19:33.361529316 +1100


This patch should no longer be required with meson.

jtojnar · 2018-10-26T04:16:44Z

pkgs/applications/networking/modem-manager-gui/default.nix

+{ stdenv, buildEnv, pkgconfig, python3, fetchhg, gtk3, glib, gdbm, gtkspell3, itstool, libappindicator-gtk3, perldevelPackages, glibcLocales, meson, ninja }:
+
+stdenv.mkDerivation rec {
+  name = "modem-manager-gui";


name is supposed to be modem-manager-gui-${version}. At least until NixOS/rfcs#35 is implemented.

jtojnar · 2018-10-26T04:19:06Z

pkgs/applications/networking/modem-manager-gui/default.nix

+stdenv.mkDerivation rec {
+  name = "modem-manager-gui";
+  version = "0.4.17";
+  rev = "v${version}";


Why is this here?

a copy-paste error

jtojnar · 2018-10-26T04:22:38Z

pkgs/applications/networking/modem-manager-gui/default.nix

+
+  meta = with stdenv.lib; {
+    homepage = https://linuxonly.ru/page/modem-manager-gui;
+    description = ''


description is supposed to be short: see https://repology.org/metapackage/modem-manager-gui/information#Summaries for what other distros use. You can add this to longDescription.

jtojnar · 2018-10-26T04:26:54Z

In case you want ofono, I have packaged it in this branch: https://github.com/jtojnar/nixpkgs/tree/librem-phone

alesya-h · 2018-10-26T05:31:53Z

@jtojnar thanks. ModemManager backend works for my hardware, so maybe another time.

jtojnar · 2018-10-26T07:04:02Z

pkgs/top-level/perl-packages.nix

@@ -12389,7 +12389,7 @@ let
      export PERL_MB_OPT="--install_base=$out --prefix=$out"
      substituteInPlace Po4aBuilder.pm --replace "\$self->install_sets(\$self->installdirs)->{'bindoc'}" "'$out/share/man/man1'"
    '';
-    buildPhase = "perl Build.PL --install_base=$out; ./Build build";
+    buildPhase = "perl Build.PL --install_base=$out --install_path=\"sbin=$out/bin\" --install_path=\"lib=$out/lib/perl5/site_perl\"; ./Build build ";


Why a this needed?

Is not there something like python.sitePackages for Perl so the path does not need to be specified manually?

I don't know what python.sitePackages is. Without this change the package was broken - whenever you try to run it's executables the app can't find it's own packages. I copied this buildPhase from another perl package and it fixed that issue.

Try perl.libPrefix, see https://github.com/NixOS/nixpkgs/blob/b547594fa67cd667678b628093ca031b941a3457/pkgs/development/interpreters/perl/default.nix#L105

--install_path=\"lib=$out/${perl.libPrefix}\" seems to be enough. Also no need for adding the final space.

jtojnar · 2018-10-30T20:55:55Z

Thank you.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 24, 2018

Synthetica9 reviewed Oct 24, 2018

View reviewed changes

pkgs/applications/networking/modem-manager-gui/default.nix Outdated Show resolved Hide resolved

alesya-h changed the title ~~Package network-manager-gui~~ Package modem-manager-gui Oct 24, 2018

jtojnar reviewed Oct 24, 2018

View reviewed changes

jtojnar reviewed Oct 25, 2018

View reviewed changes

jtojnar reviewed Oct 26, 2018

View reviewed changes

alesya-h added 2 commits October 30, 2018 21:55

perlPackages.Po4a: fix install paths

29080af

modem-manager-gui: init at 0.0.19.1

6d34e36

jtojnar force-pushed the package-network-manager-gui branch from 2bd2aaf to 6d34e36 Compare October 30, 2018 20:55

jtojnar merged commit 6d34e36 into NixOS:master Oct 30, 2018

GrahamcOfBorg added 10.rebuild-linux: 0 and removed 10.rebuild-linux: 1-10 labels Oct 30, 2018

alesya-h deleted the package-network-manager-gui branch November 5, 2018 02:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package modem-manager-gui #48959

Package modem-manager-gui #48959

alesya-h commented Oct 24, 2018

jtojnar Oct 24, 2018

alesya-h Oct 25, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018

jtojnar Oct 24, 2018

alesya-h Oct 25, 2018

jtojnar Oct 24, 2018

jtojnar Oct 24, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018

alesya-h Oct 25, 2018

jtojnar Oct 25, 2018 •

edited

alesya-h Oct 26, 2018

jtojnar Oct 26, 2018

jtojnar Oct 26, 2018

alesya-h Oct 26, 2018

alesya-h Oct 26, 2018

jtojnar Oct 26, 2018

alesya-h Oct 26, 2018

jtojnar commented Oct 26, 2018

alesya-h commented Oct 26, 2018

jtojnar Oct 26, 2018

alesya-h Oct 26, 2018

jtojnar Oct 26, 2018

jtojnar Oct 26, 2018

alesya-h Oct 28, 2018

jtojnar commented Oct 30, 2018

		@@ -0,0 +1,16 @@
		--- a/configure 2018-10-25 14:19:33.361529316 +1100

Package modem-manager-gui #48959

Package modem-manager-gui #48959

Conversation

alesya-h commented Oct 24, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar Oct 25, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Oct 26, 2018

alesya-h commented Oct 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Oct 30, 2018

jtojnar Oct 25, 2018 •

edited