Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r8168: init at 8.046.00 #48921

Merged
merged 1 commit into from Oct 24, 2018
Merged

r8168: init at 8.046.00 #48921

merged 1 commit into from Oct 24, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 23, 2018

Motivation for this change

My network card defaults to the r8169 driver. That however has a bug where it sometimes stops working after a suspend. So I'm packaging the alternative, which works flawless.

@samueldr since just picking this package from the unstable channel isn't feasible (kernel versions have to match), would it be okay if I also add this to release-18.09?

Also this is my first kernel module so I'd appreciate it if someone reviews this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Oct 24, 2018

I'm going to go ahead and merge this now and open another PR for the backport.

@timokau timokau merged commit e89b422 into NixOS:master Oct 24, 2018
@timokau timokau mentioned this pull request Oct 24, 2018
9 tasks
@timokau timokau deleted the r8168 branch October 24, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants