Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tealdeer: 1.0.0 -> 1.1.0 #48918

Merged
merged 1 commit into from Oct 24, 2018
Merged

tealdeer: 1.0.0 -> 1.1.0 #48918

merged 1 commit into from Oct 24, 2018

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 23, 2018 •
edited

bump tealdeer version to 1.1.0 and adapt meta.description to changed upstream README.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@das-g
tealdeer: 1.0.0 -> 1.1.0
090889f 
and adapt description to changed upstream README.
@xeji
Copy link
Contributor

xeji commented Oct 24, 2018

@GrahamcOfBorg build tealdeer

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tealdeer

Partial log (click to expand)

    Finished release [optimized] target(s) in 2m 09s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0
shrinking /nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0/bin/tldr
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0/bin
patching script interpreter paths in /nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0
checking for references to /build in /nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0...
/nix/store/jahcdilfnkrxyjyxiwjachm5bgmrr9yw-tealdeer-1.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tealdeer

Partial log (click to expand)

    Finished release [optimized] target(s) in 5m 46s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0
shrinking /nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0/bin/tldr
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0/bin
patching script interpreter paths in /nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0
checking for references to /build in /nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0...
/nix/store/wvi7y6nbjlgf6ih1xdkzk4b7srp2ws86-tealdeer-1.1.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: tealdeer

Partial log (click to expand)

cannot build derivation '/nix/store/kpjx1rkz98x4cj163rr5kgwszh3afgyg-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/rjx3a0q6wg19y9b6id7sqy0jp2nrxkx5-rust_crates-io-0.11.0.drv': 27 dependencies couldn't be built
cannot build derivation '/nix/store/8aggs5cv8ifg0l6b15bbf9p07la74jzp-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/bn3l5khz2a646c1dmpjk3k39hyjfqysq-rust_git2-curl-0.7.0.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/qb9hmvy8mjpiakgiim6hbrhbnj0k2y4q-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/qjzkag4bh1gipi327ih2h27c2g23ifhq-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/1wmw79b95m418fa4799sclb6pl9mhakr-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/isykh8ax2xk080yc0icmhvgg4da81zfg-tealdeer-1.1.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/g3iq8qvppm06jl15kiyh5w4zmda00smb-tealdeer-1.1.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/g3iq8qvppm06jl15kiyh5w4zmda00smb-tealdeer-1.1.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 24, 2018

cc @davidak

davidak
davidak approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your contribution.

@xeji xeji merged commit 12a658a into NixOS:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@das-g @xeji @GrahamcOfBorg @davidak