Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: 0.17.4 -> 0.17.5 #48944

Merged
merged 1 commit into from Oct 24, 2018
Merged

fzf: 0.17.4 -> 0.17.5 #48944

merged 1 commit into from Oct 24, 2018

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes: https://github.com/junegunn/fzf/blob/master/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Oct 24, 2018

@GrahamcOfBorg build fzf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fzf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5
checking for references to /build in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man
gzipping man pages under /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man
checking for references to /build in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man...
/nix/store/b6gxqngpwhpa975wjvpi4kdpl9zzysng-fzf-0.17.5-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fzf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5
checking for references to /build in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man
gzipping man pages under /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man
checking for references to /build in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man...
/nix/store/jjgmk73hbc5w11q8v29jgzng94xxv7g7-fzf-0.17.5-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fzf

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin
patching script interpreter paths in /nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin/fzf-share: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin/fzf-tmux: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/m9vkh55xah903jmzb3hm5rqj80akbzna-fzf-0.17.5
gzipping man pages under /nix/store/riwi28pa5ahpr2p3p9h7iz4nzfyf4n93-fzf-0.17.5-man/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/riwi28pa5ahpr2p3p9h7iz4nzfyf4n93-fzf-0.17.5-man
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin

@LnL7 LnL7 merged commit e38b903 into NixOS:master Oct 24, 2018
@danieldk danieldk deleted the fzf-0.17.5 branch October 25, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @LnL7 @GrahamcOfBorg