Updated mysql Package to support the change of root password of the mysql-server #48913
Conversation
Ensure Databases and User does not work if the root password has changed
|
Please improve the commit title to describe what Nixpkgs attribute is modified, and what the change is roughly about. |
TheZyppi
changed the title
|
Done |
There was a problem hiding this comment.
Hi! 👋
First of all, thanks for contributing, not always easy to get a first contribution into an established project!
Though, I'm sorry, this PR cannot be merged as-it-is in release-18.09.
- This is not a backport of a change from
master - The change is possibly not doing the right thing
More explanation follows.
Not a backport
Most changes to the behaviour of NixOS modules will mirror changes made in the master branch. And few of those changes are actually backported, mostly for forward and backward compatibility's sake, or to fix bugs.
In this particular case, the change would need to be made on master first, then reviewed and merged on master before going into release-18.09 (the current stable).
The change is possibly not doing the right thing
The configuration option used, rootPassword does not contain the root password:
rootPassword: Path to a file containing the root password, modified on the first startup. Not specifying a root password will leave the root password empty.
This means that the current change will pass a filename as the -p parameter to the mysql command.
|
(triage) closing this PR.
If the change is still wanted, please re-open a new PR, targeting master. Thanks again for wanting to contribute, though! |
Ensure Databases and User does not work if the root password has changed
Motivation for this change
Trying to use mysqlBackup with changed root password. ... not working
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)