Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-cpp: fix for zstd 1.3.6+ #48928

Merged
merged 1 commit into from Oct 24, 2018
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 23, 2018

Motivation for this change

Workaround facebook/zstd#1385

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl veprbl changed the title arrow-cpp: fix for zstd 1.2.6+ arrow-cpp: fix for zstd 1.3.6+ Oct 23, 2018
@veprbl
Copy link
Member Author

veprbl commented Oct 23, 2018

@GrahamcOfBorg build arrow-cpp python2Packages.pyarrow python3Packages.pyarrow

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: arrow-cpp

Partial log (click to expand)

these derivations will be built:
  /nix/store/mav58d6xlzg0588lwpa7pri7ra2ypps4-arrow-cpp-0.11.0.drv
waiting for locks or build slots...
/nix/store/ynnd3lx3fzfn5kza1rv8yx8ns6bpg4mf-arrow-cpp-0.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arrow-cpp

Partial log (click to expand)

57: /build/apache-arrow-0.11.0/cpp/build/src/parquet/util
56/56 Test #57: parquet-memory-test ................   Passed    0.05 sec

100% tests passed, 0 tests failed out of 56

Label Time Summary:
parquet     =  14.70 sec*proc (18 tests)
unittest    = 110.12 sec*proc (56 tests)

Total Test time (real) = 110.15 sec

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow

Partial log (click to expand)

  /nix/store/v79j930zcqf9nygp01zl0zjb53mqa969-python2.7-pandas-0.23.4/lib/python2.7/site-packages/pandas/core/internals.py:312: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    return self.values[slicer]
  /nix/store/v79j930zcqf9nygp01zl0zjb53mqa969-python2.7-pandas-0.23.4/lib/python2.7/site-packages/pandas/core/indexes/datetimelike.py:428: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    result = getitem(key)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 5 failed, 16896 passed, 1030 skipped, 11887 deselected, 37 xfailed, 2 xpassed, 6 warnings in 593.95 seconds
builder for '/nix/store/sfgg7h8zc274x7n3c4v97bjgsv4djrbz-python2.7-pandas-0.23.4.drv' failed with exit code 1
cannot build derivation '/nix/store/ag148r8bd68b3913285z0s2pny1xlafg-python2.7-pyarrow-0.11.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0b1ld60bs98i9pk6dn9r0hicknbxwr0b-python3.6-pyarrow-0.11.0.drv', '/nix/store/ag148r8bd68b3913285z0s2pny1xlafg-python2.7-pyarrow-0.11.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: arrow-cpp

Partial log (click to expand)

57: /private/tmp/nix-build-arrow-cpp-0.11.0.drv-0/apache-arrow-0.11.0/cpp/build/src/parquet/util
56/56 Test #57: parquet-memory-test ................   Passed    0.14 sec

100% tests passed, 0 tests failed out of 56

Label Time Summary:
parquet     = 111.44 sec*proc (18 tests)
unittest    = 884.66 sec*proc (56 tests)

Total Test time (real) = 899.70 sec

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow

Partial log (click to expand)

Moving generated C++ source _parquet.cpp to build path /build/apache-arrow-0.11.0/python/pyarrow/_parquet.cpp
Moving built C-extension release/_parquet.cpython-36m-x86_64-linux-gnu.so to build path /build/apache-arrow-0.11.0/python/pyarrow/_parquet.cpython-36m-x86_64-linux-gnu.so
release/_orc.cpython-36m-x86_64-linux-gnu.so
Cython module _orc failure permitted
release/_plasma.cpython-36m-x86_64-linux-gnu.so
Cython module _plasma failure permitted
pytestcachePhase
/nix/store/jwmryl6i1qrksnizml0jx7ldxxy59j17-arrow-cpp-0.11.0
/nix/store/xm2qlasz4gl2y0bn0m0rzbd4v0qri2am-python2.7-pyarrow-0.11.0
/nix/store/zz6cs2cnnfyw452qqrkcppkvcvp45446-python3.6-pyarrow-0.11.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow

Partial log (click to expand)

    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/nix/store/0mha803yql9q7b6h93m8940z3sjbhiy8-python3-3.6.6/lib/python3.6/unittest/loader.py", line 219, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/nix/store/0mha803yql9q7b6h93m8940z3sjbhiy8-python3-3.6.6/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/private/tmp/nix-build-python3.6-pyarrow-0.11.0.drv-0/apache-arrow-0.11.0/python/pyarrow/__init__.py", line 45, in <module>
    import pyarrow.compat as compat
AttributeError: module 'pyarrow' has no attribute 'compat'
builder for '/nix/store/z5zqhsq3x866w83awxynrpvpvcx2gabm-python3.6-pyarrow-0.11.0.drv' failed with exit code 1
error: build of '/nix/store/z5zqhsq3x866w83awxynrpvpvcx2gabm-python3.6-pyarrow-0.11.0.drv', '/nix/store/z9g3spxg9vvgn69lbn2lpxixf2gz1z4c-python2.7-pyarrow-0.11.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 24, 2018

LGTM. The pyarrow failures exist without this PR.

@xeji xeji merged commit c88e09d into NixOS:master Oct 24, 2018
@pitrou
Copy link

pitrou commented Nov 6, 2018

@veprbl In the future could you also report such issues upstream? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants