signify: init at v24 #48927

rlupton20 · 2018-10-23T23:19:31Z

Motivation for this change

signify is a neat, simple and tidy signing utility built for OpenBSD. It is packaged on a couple of linux distributions already, and I thought it would be useful on nixos.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

c0bw3b · 2018-10-24T09:43:46Z

Just FYI we already have minisign in Nixpkgs which is supposed to be compatible with OpenBSD signify

pkgs/tools/security/signify/default.nix

rlupton20 · 2018-10-24T23:18:07Z

Review feedback applied, squashed commits.

joachifm · 2018-10-25T07:34:58Z

@GrahamcOfBorg build signify

GrahamcOfBorg · 2018-10-25T07:35:18Z

Success on aarch64-linux (full log)

Attempted: signify

Partial log (click to expand)

install -m 644 -t /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24/share/man/man1 signify.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24
shrinking /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24/bin/signify
gzipping man pages under /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24/bin
patching script interpreter paths in /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24
checking for references to /build in /nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24...
/nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24

GrahamcOfBorg · 2018-10-25T07:35:21Z

Failure on x86_64-darwin (full log)

Attempted: signify

Partial log (click to expand)

sha2.c:952:1: error: only weak aliases are supported on darwin
MAKE_CLONE(SHA512_256Pad, SHA512Pad);
^
./compat.h:30:20: note: expanded from macro 'MAKE_CLONE'
                                __attribute__((alias (#src)))
                                               ^
16 errors generated.
make: *** [<builtin>: sha2.o] Error 1
builder for '/nix/store/6bbfj7c6h65x6l3wnrp90wwc7caqxk17-signify-24.drv' failed with exit code 2
error: build of '/nix/store/6bbfj7c6h65x6l3wnrp90wwc7caqxk17-signify-24.drv' failed

GrahamcOfBorg · 2018-10-25T07:35:45Z

Success on x86_64-linux (full log)

Attempted: signify

Partial log (click to expand)

install -m 644 -t /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/share/man/man1 signify.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24
shrinking /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/bin/signify
gzipping man pages under /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/bin
patching script interpreter paths in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24
checking for references to /build in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24...
/nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24

joachifm · 2018-10-25T12:14:08Z

The darwin error looks legit, consider constraining the list of platforms if it cannot be easily worked around.

rlupton20 · 2018-10-25T16:42:35Z

Yep - not sure I have an effective way to debug this, but I'll look into it, and restrict if necessary.

rlupton20 · 2018-10-25T16:47:35Z

Bit of googling suggests this may be something that can be circumvented by using gcc instead of clang as the C compiler on darwin. Will see if I can get that to work.

rlupton20 · 2018-10-25T17:11:43Z

@GrahamcOfBorg build signify

joachifm · 2018-10-25T18:02:30Z

@GrahamcOfBorg build signify

GrahamcOfBorg · 2018-10-25T18:02:47Z

Failure on x86_64-darwin (full log)

Attempted: signify

Partial log (click to expand)

configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash
/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash: git: command not found
gcc -I/nix/store/bg9nfv6bp21cg81v83raafwci74fxvn3-libbsd-0.9.1/include -Wall -include compat.h -DBUNDLED_BZERO=1  -c -o crypto_api.o crypto_api.c
/nix/store/xs8x90rif8vp3ymhdyqpc66cx0l7s2c9-gcc-wrapper-7.3.0/bin/as: assembler (clang) not installed
make: *** [<builtin>: crypto_api.o] Error 1
builder for '/nix/store/y44rji9brqv173hx5pg92nj130b2c4g6-signify-24.drv' failed with exit code 2
error: build of '/nix/store/y44rji9brqv173hx5pg92nj130b2c4g6-signify-24.drv' failed

GrahamcOfBorg · 2018-10-25T18:02:47Z

Success on aarch64-linux (full log)

Attempted: signify

Partial log (click to expand)

install -m 644 -t /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24/share/man/man1 signify.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24
shrinking /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24/bin/signify
gzipping man pages under /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24/bin
patching script interpreter paths in /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24
checking for references to /build in /nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24...
/nix/store/cvbaxj5mmck1q0in46f2zlkxdckz40qi-signify-24

GrahamcOfBorg · 2018-10-25T18:03:45Z

Success on x86_64-linux (full log)

Attempted: signify

Partial log (click to expand)

install -m 644 -t /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24/share/man/man1 signify.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24
shrinking /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24/bin/signify
gzipping man pages under /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24/bin
patching script interpreter paths in /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24
checking for references to /build in /nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24...
/nix/store/xbmdbi2yfgwihf9z0ia511wbkmap8adi-signify-24

rlupton20 · 2018-10-25T18:16:26Z

OK - I'm not going to keep trying it this way - I suspect this can be gotten to build on darwin, but iterating with the bot is tedious. I'll limit the platform for now, and leave it to a Mac user to open it up more generally.

rlupton20 · 2018-10-25T18:20:50Z

Ok, limited to linux and squashed.

Let's try this again...

rlupton20 · 2018-10-25T18:21:27Z

@GrahamcOfBorg build signify

pkgs/tools/security/signify/default.nix

joachifm · 2018-10-25T18:25:40Z

Note that you need to be registered with the bot to issue commands, see https://github.com/NixOS/ofborg

Initial markups Fix derivation versioning Force use of gcc Limit to linux

joachifm · 2018-10-25T19:05:04Z

@GrahamcOfBorg build signify

GrahamcOfBorg · 2018-10-25T19:05:13Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signify

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-25T19:05:16Z

Success on aarch64-linux (full log)

Attempted: signify

Partial log (click to expand)

/nix/store/hkhhvqc292sdlj0gbgaqw3linlklj8bd-signify-24

GrahamcOfBorg · 2018-10-25T19:05:29Z

Success on x86_64-linux (full log)

Attempted: signify

Partial log (click to expand)

install -m 644 -t /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/share/man/man1 signify.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24
shrinking /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/bin/signify
gzipping man pages under /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24/bin
patching script interpreter paths in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24
checking for references to /build in /nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24...
/nix/store/yapwszlh4fi4li48mxmmjkwzfs05x4v5-signify-24

joachifm · 2018-10-25T19:08:55Z

Thank you

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 23, 2018

c0bw3b reviewed Oct 24, 2018

View reviewed changes

pkgs/tools/security/signify/default.nix Outdated Show resolved Hide resolved

pkgs/tools/security/signify/default.nix Outdated Show resolved Hide resolved

pkgs/tools/security/signify/default.nix Outdated Show resolved Hide resolved

joachifm reviewed Oct 24, 2018

View reviewed changes

pkgs/tools/security/signify/default.nix Outdated Show resolved Hide resolved

rlupton20 force-pushed the package-signify branch from 7e9376e to 1ace3b0 Compare October 24, 2018 23:16

rlupton20 force-pushed the package-signify branch from dd3bb04 to d3afa42 Compare October 25, 2018 18:20

joachifm reviewed Oct 25, 2018

View reviewed changes

pkgs/tools/security/signify/default.nix Outdated Show resolved Hide resolved

GrahamcOfBorg added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Oct 25, 2018

Signify: init at v24

c4a99a5

Initial markups Fix derivation versioning Force use of gcc Limit to linux

rlupton20 force-pushed the package-signify branch from d3afa42 to c4a99a5 Compare October 25, 2018 18:50

joachifm merged commit b28552d into NixOS:master Oct 25, 2018

coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Oct 26, 2018

signify: init at 24 (NixOS#48927)

131c208

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

signify: init at v24 #48927

signify: init at v24 #48927

rlupton20 commented Oct 23, 2018

c0bw3b commented Oct 24, 2018

rlupton20 commented Oct 24, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

joachifm commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

joachifm commented Oct 25, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

joachifm commented Oct 25, 2018

signify: init at v24 #48927

signify: init at v24 #48927

Conversation

rlupton20 commented Oct 23, 2018

Motivation for this change

Things done

c0bw3b commented Oct 24, 2018

rlupton20 commented Oct 24, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

joachifm commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

rlupton20 commented Oct 25, 2018

joachifm commented Oct 25, 2018

joachifm commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

joachifm commented Oct 25, 2018