Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.owslib: init at 0.17.0 #48914

Merged
merged 1 commit into from Nov 6, 2018
Merged

pythonPackages.owslib: init at 0.17.0 #48914

merged 1 commit into from Nov 6, 2018

Conversation

lsix
Copy link
Member

@lsix lsix commented Oct 23, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lsix lsix requested a review from FRidh as a code owner October 23, 2018 20:20
FRidh
FRidh requested changes Oct 24, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/OWSLib/default.nix Outdated Show resolved Hide resolved
@lsix lsix changed the title pythonPackages.OWSLib: init at 0.17.0 pythonPackages.owslib: init at 0.17.0 Oct 24, 2018
@lsix lsix merged commit 1aed180 into NixOS:master Nov 6, 2018
@lsix lsix deleted the add_pythonPackages_owslib branch August 22, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @FRidh @GrahamcOfBorg