nodejs: init at 11.5.0 #48911
nodejs: init at 11.5.0 #48911
Conversation
|
@GrahamcOfBorg build nodejs-11_x |
|
Failure on aarch64-linux (full log) Attempted: nodejs-11_x Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: nodejs-11_x Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: nodejs-11_x Partial log (click to expand)
|
|
I tried to build this locally, but I ran into the same issue as borg. It failed with the following tail: It seemed to have just cut off the log somewhere at the end. Running the build takes quite a while, so I haven't figured out why this happens. Any ideas? |
|
I get the same error on nixos. It seems like something related to the build of |
|
nodejs 11.1.0 released: https://nodejs.org/en/blog/release/v11.1.0/ |
|
@marsam No, just building on zsh. It also says |
|
FYI the borg is currently experiencing similar issues on aarch64 in #49453, did all of you test the Linux build with sandbox enabled? @bobvanderlinden it would be awesome if you could rerun (if the logs are missing) and post the log output into a github gist if possible :) EDIT: I compiled nodejs v11 locally on my machine (x86-linux) and it works here as well... |
|
Yes, on NixOS with sandbox enabled. Rebuild it today and again the same result (yay determinism). Ran |
|
So... as the build seems to have aborted in the middle of the install phase (so did borg, but earlier) without an (obvious) failure, I can currently think of two possibilities:
|
|
@selaux can you give this a try 👆? |
|
Another possible cause is lack of memory. I wasn't tracking the memory, but I can imagine Nix or the system is running out of its max memory (for the sandbox?). I'm not sure if there are limitations in that regard. |
I made a different experience. I built this PR multiple times on different machines and at one point the build succeeded on a machine where it previously failed. But this happened only a single time out of about 10 builds. |
|
Increasing timeouts does not work for me either. Here is a build log of a failing build using |
|
@selaux thanks a lot for looking into this! Your build log is more or less the same as the one of @bobvanderlinden, it suddenly aborts during install phase. When you run |
|
No, nothing. Just: Can I somehow increase verbosity for the nix-daemon? |
|
Unfortunately I didn't find anything useful in the man page and the I'll try a local build tonight (maybe this makes a difference) and posted this PR into |
|
Short update from my side: I just tried to build nodejs 11 locally (while doing some additional work, so IDE and stuff eating resources as well) and now it breaks the build which confirms the assumption that this is somehow related to limited resources on the building machine. I'm not exactly sure how to proceed here, I added this to my TODO list and I'm planning to have a deeper look at this next weekend. (If anybody wants to take over, feel free :P) |
|
I managed to compile this using The |
|
I ran it again with: But got the same behaviour: I also tried setting it to 1, but that didn't timeout the build! I think the timeout option in meta is not a valid option. Also note that I tried: But that outputs the following: So, the timeout option of nix-build does output that the build did timeout after X seconds. That does not happen for the failing build, so I'm still unsure whether timeouts are related. |
|
thanks a lot for your report! Admittedly I'm slightly confused, but as this issue isn't 100% reproducible either, I could've had "bad luck" while building locally :) Please give me some more time until tomorrow, I'll see when |
|
@bobvanderlinden I had another look at this last night and I can confirm that my previous report was premature and unfortunately a false-positive, I'm sorry for that. After having a look at the sources it seems as this meta option is only used by Hydra to determine build timeouts in jobsets. It's most likely that my local build from the 16th November passed due to a low load on my machine. Yesterday I partly got passing builds locally, but I managed to reliably reproduce the build failures by running In case this is helpful for anybody, I ran the build with I'm truly sorry, but I'm afraid that this issue exceeds my knowledge about how Nix works internally. For now I'm pinging @cillianderoiste, @gilligan and @cko as they're listed as NodeJS maintainers. Do you folks have an idea what might go wrong here? Of course I'll read the notifications about this thread and try to help, but I could use some support of people with more experience about Nix and/or NodeJS internals :) |
|
All of this sounds rather weird indeed. I’ll try to have a look asap and will ping some other folks if I don’t find anything either.. |
|
wild guess, can you try increasing the size of the tmp folder? |
|
nodejs v11.5.0 released https://nodejs.org/en/blog/release/v11.5.0/ Can we get this merged? I can build it on Darwin and NixOS |
|
@lo1tuma @bobvanderlinden did anybody of you try this? |
|
@Ma27 Tried again after rebasing on master, same issue still persists. My Regarding nodejs |
|
I updated the PR for I invested a little time and it seems like NodeJS Please test the current version. I still don't understand why the |
|
Updated the PR's title. Unfortunately I don't know |
|
@Ma27 Can you trigger @GrahamcOfBorg so we can see if it builds everywhere? |
|
@GrahamcOfBorg build nodejs-11_x nodejs-slim-11_x |
|
LGTM - someone with merge permissions please hit the green button ;-) |
|
Builds fine for me on NixOS and Darwin, let's merge this :) |
|
seen the notification just now, thanks to everyone who helped getting this working! |
Motivation for this change
New major release of nodejs.
Release Notes.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)