New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-sql-proxy: 1.11 -> 1.13 #48920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to make sure: did you check for potential updates to |
nicknovitski
force-pushed
the
cloud-sql-proxy-1.13
branch
from
October 25, 2018 17:48
96819e3
to
0b46966
Compare
I did, but I realized I did it wrong. Updated with deps.nix changes. |
@GrahamcOfBorg build cloud-sql-proxy |
Success on aarch64-linux (full log) Attempted: cloud-sql-proxy Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: cloud-sql-proxy Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: cloud-sql-proxy Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11 broke 1.11: GoogleCloudPlatform/cloud-sql-proxy#194
sandbox
innix.conf
on non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)