Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Fabric, pythonPackages.paramiko, pythonPacakges.pytest-relaxed #48170

Merged
merged 3 commits into from Oct 13, 2018
Merged

pythonPackages.Fabric, pythonPackages.paramiko, pythonPacakges.pytest-relaxed #48170

merged 3 commits into from Oct 13, 2018

Conversation

costrouc
Copy link
Member

Things done

pythonPackages.pytest-relaxed: init at 1.1.4

pythonPackages.paramiko: 2.1.1 -> 2.4.2 refactor move to python-modules

pythonPackages.Fabric: 1.13.2 -> 2.4.0 refactor move to python-modules

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner October 10, 2018 18:29
@xeji
Copy link
Contributor

xeji commented Oct 10, 2018

Please rebase this on the staging branch as it causes a mass rebuild.

@costrouc costrouc changed the base branch from master to staging October 10, 2018 20:23
@costrouc
Copy link
Member Author

You can ignore the newest added tags. It has to do with me rebasing improperly. Should be rebased properly now.

@xeji
Copy link
Contributor

xeji commented Oct 10, 2018

Not to worry, ofborg frequently adds wrong tags when changing base...

@xeji xeji removed request for Mic92 and LnL7 October 10, 2018 20:38
@FRidh FRidh merged commit 49719ae into NixOS:staging Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @xeji @FRidh @GrahamcOfBorg