Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isSimpleBuild to generated derivations #380

Closed
wants to merge 1 commit into from
Closed

Add isSimpleBuild to generated derivations #380

wants to merge 1 commit into from

Conversation

duog
Copy link

@duog duog commented Oct 10, 2018

This will allow generic-builder.nix to use a shared Setup executable for all
packages that have isSimpleBuild = true. The default must be false, for
safety, even though almost all packages are simple.

@duog
Add isSimpleBuild to generated derivations
d39f411 
This will allow generic-builder.nix to use a shared Setup executable for all
packages that have `isSimpleBuild = true`. The default must be false, for
safety, even though almost all packages are simple.
peti
peti requested changes Oct 12, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to expose the build-type completely, i.e. have buildType = "simple" for simple builds and "custom", "autoconf", etc. for others.

@peti
Copy link
Member

peti commented Nov 28, 2018

Ping?

@peti peti closed this Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duog @peti