Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dia: fix on darwin #48176

Merged
merged 1 commit into from Oct 10, 2018
Merged

dia: fix on darwin #48176

merged 1 commit into from Oct 10, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 10, 2018

Fixes runtime error:
GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl
dia: fix on darwin
cf96160 
Fixes runtime error:
  GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dia

Partial log (click to expand)

these paths will be fetched (3.39 MiB download, 19.86 MiB unpacked):
  /nix/store/5gan76hzgrgkvvdyg5hj0653f5lz79wi-libxslt-1.1.32
  /nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-0.97.3.20170622
copying path '/nix/store/5gan76hzgrgkvvdyg5hj0653f5lz79wi-libxslt-1.1.32' from 'https://cache.nixos.org'...
copying path '/nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-0.97.3.20170622' from 'https://cache.nixos.org'...
/nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-0.97.3.20170622

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dia

Partial log (click to expand)

these paths will be fetched (3.44 MiB download, 19.83 MiB unpacked):
  /nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-0.97.3.20170622
copying path '/nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-0.97.3.20170622' from 'https://cache.nixos.org'...
/nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-0.97.3.20170622

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dia

Partial log (click to expand)

/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-0.97.3.20170622

@xeji xeji added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 10, 2018
@xeji xeji merged commit c047572 into NixOS:master Oct 10, 2018
xeji pushed a commit that referenced this pull request Oct 10, 2018
@veprbl @xeji
dia: fix on darwin (#48176)
abd6a5b 
Fixes runtime error:
  GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported

(cherry picked from commit c047572)
@xeji
Copy link
Contributor

xeji commented Oct 10, 2018

backported to 18.09: abd6a5b

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 14, 2019
@veprbl veprbl deleted the pr/dia_gtk_fix branch December 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji