Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prooftree: cleaning #48168

Merged
merged 1 commit into from Oct 11, 2018
Merged

prooftree: cleaning #48168

merged 1 commit into from Oct 11, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 10, 2018

Motivation for this change

#48159

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jwiegley, maintainer.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prooftree

Partial log (click to expand)

cp prooftree.1 /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13
shrinking /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/bin/prooftree
gzipping man pages under /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/bin
patching script interpreter paths in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13
checking for references to /build in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13...
/nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prooftree

Partial log (click to expand)

mkdir -p /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/bin
cp prooftree /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/bin
mkdir -p /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/share/man/man1
cp prooftree.1 /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13/bin
patching script interpreter paths in /nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13
/nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prooftree

Partial log (click to expand)

cp prooftree.1 /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13
shrinking /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/bin/prooftree
gzipping man pages under /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/bin
patching script interpreter paths in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13
checking for references to /build in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13...
/nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13

timokau
timokau reviewed Oct 10, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -21277,10 +21277,7 @@ with pkgs;

libpoly = callPackage ../applications/science/logic/poly {};

prooftree = (with ocaml-ng.ocamlPackages_4_01_0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there maybe a reason this specific version of ocaml was used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it was not compatible with our default, newer ocaml before that.

@vbgl vbgl changed the title prooftree: 0.12 -> 0.13 prooftree: cleaning Oct 11, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prooftree

Partial log (click to expand)

cp prooftree.1 /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13
shrinking /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/bin/prooftree
gzipping man pages under /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13/bin
patching script interpreter paths in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13
checking for references to /build in /nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13...
/nix/store/yzdxx3glxs204305m9dbv9d128jdxz27-prooftree-0.13

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prooftree

Partial log (click to expand)

/nix/store/5nwd79k5jbili3150ph9dnggsz466lwi-prooftree-0.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prooftree

Partial log (click to expand)

cp prooftree.1 /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13
shrinking /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/bin/prooftree
gzipping man pages under /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13/bin
patching script interpreter paths in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13
checking for references to /build in /nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13...
/nix/store/xd6ww87h1d8rxj2alg3xyczn7g2166n7-prooftree-0.13

@Mic92 Mic92 merged commit 01cca59 into NixOS:master Oct 11, 2018
@vbgl vbgl deleted the prooftree-0.13 branch October 16, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@timokau timokau timokau left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @GrahamcOfBorg @Mic92 @timokau