httping: add libintl to buildInputs on Darwin #48188
Conversation
GrahamcOfBorg
added
6.topic: darwin
|
@GrahamcOfBorg build httping |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: httping Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: httping Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: httping Partial log (click to expand)
|
| @@ -29,6 +29,6 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
| license = licenses.agpl3; | |||
| maintainers = with maintainers; [ rickynils ]; | |||
| platforms = platforms.linux; | |||
| platforms = [ "x86_64-linux" ] ++ platforms.darwin; | |||
There was a problem hiding this comment.
Why restrict the package to x86_64-linux when it seems to work on all linux platforms, i.e. aarch64?
https://hydra.nixos.org/job/nixos/unstable-aarch64/nixpkgs.httping.aarch64-linux
There was a problem hiding this comment.
@fpletz That was a mistake. Now fixed :)
There was a problem hiding this comment.
Unrelated to your changes but there is also a problem with TLS transport since the server cert is only valid for vanheusden.com and not www.vanheusden.com
So src.url and meta.homepage also need updating:
url = "https://vanheusden.com/httping/${name}.tgz";homepage = https://vanheusden.com/httping/
|
@c0bw3b Actually it has a GitHub repo: https://github.com/flok99/httping. Would it be better if we fetch source from GitHub? |
|
For fetching the source archive yes. I guess the GH repo could be considered more stable over time. Set the homepage to the "real" author page though. |
| @@ -10,7 +10,7 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1y7sbgkhgadmd93x1zafqc4yp26ssiv16ni5bbi9vmvvdl55m29y"; | |||
| }; | |||
|
|
|||
| buildInputs = [ fftw ncurses openssl ]; | |||
| buildInputs = [ fftw ncurses openssl ] ++ (with stdenv; lib.optional isDarwin libintl); | |||
There was a problem hiding this comment.
Since libintl is null on Glibc Linux, you don't need the lib.optional part. It can just be listed a build inputs. As a plus, this makes your changes compatible with other libcs that don't come with libintl like Musl!
There was a problem hiding this comment.
@matthewbauer I didn't know that. Thanks!
Otherwise it won't compile.
|
@c0bw3b I've updated |
|
@iwinux this is good to go this way. When pulling source archives from GitHub or other git forges the SHA hash is computed on the content of the archive after unpacking. That hash can be computed manually with For this simple package we can avoid that and just fetch the stable source archive the author is publishing on its website. |
* httping: add libintl to buildInputs on Darwin Otherwise it won't compile. * httping: fix URLs (cherry picked from commit 9f8b40c)
Motivation for this change
libintlto itsbuildInputs(reference: glibc: Strip bonus libraries #37056)Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Fits CONTRIBUTING.md.